-
Notifications
You must be signed in to change notification settings - Fork 45
alert-mgmt-01: k8s foundation #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sradco
wants to merge
1
commit into
openshift:alerts-management-api
Choose a base branch
from
sradco:alert-mgmt-01-k8s-foundation
base: alerts-management-api
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
prometheus/prometheus v0.308.0 release validity💡 Result:
Yes—
prometheus/prometheusv0.308.0 is a real, official GitHub release tag.v0.308.0, pointing to commite44ed35, and indicates it was tagged on Dec 2, 2025 (tagged byjan--f). [1]v0.308.0as released on Dec 2, 2025. [2]Conclusion:
v0.308.0is a valid Prometheus repository release/tag (not a fabricated version). [1]Sources: [1] GitHub release tag page, [2] ReleaseAlert release index.
🏁 Script executed:
# Find vars.go file in the repository fd vars.goRepository: openshift/monitoring-plugin
Length of output: 86
🏁 Script executed:
# Check the go.mod file to see if prometheus/prometheus dependency is listed cat go.modRepository: openshift/monitoring-plugin
Length of output: 4293
🏁 Script executed:
Repository: openshift/monitoring-plugin
Length of output: 1777
🌐 Web query:
prometheus v0.308.0 API endpoints /alerts /rules💡 Result:
In Prometheus, the HTTP API endpoints for alerts and rules are:
GET /api/v1/alerts(returns all currently active alerts) [1]GET /api/v1/rules(returns currently loaded recording + alerting rules, and includes active alerts per alerting rule) [1]/api/v1/rulesoptional query params include:type=alert|record,rule_name[]=...,rule_group[]=...,file[]=..., plus pagination viagroup_limit+group_next_token[1].Note: These are Prometheus server endpoints. If you meant Alertmanager’s alerts API (to send alerts), that’s
POST /api/v2/alertson Alertmanager, not Prometheus [2].Sources: [1] [2]
🌐 Web query:
prometheus http API paths /v1/alerts /v1/rules documentation💡 Result:
In Prometheus (server), the stable HTTP API is rooted at
/api/v1(not/v1). (prometheus.io)Active alerts (Prometheus)
GET /api/v1/alertsLoaded rules (Prometheus)
GET /api/v1/rulestype=alert|record,rule_name[],rule_group[],file[], plus pagination viagroup_next_token(withgroup_limit). (prometheus.io)Common gotcha: Alertmanager “/v1/alerts”
If you meant Alertmanager’s alerts ingestion endpoint: Alertmanager API v1 was deprecated (0.16.0) and removed (0.27.0); use
POST /api/v2/alertsinstead. (prometheus.io)Citations:
Fix API paths: add missing
/apiprefix to Prometheus endpoints.The paths defined in
vars.golines 12–13 are incorrect. The Prometheus HTTP API uses/api/v1/alertsand/api/v1/rules, not/v1/alertsand/v1/rules. This applies to prometheus/prometheus v0.308.0 and all other versions—the/apiprefix is required.Current (incorrect) paths:
Update both constants to include the
/apiprefix to match the official Prometheus API specification.🤖 Prompt for AI Agents