Migrate away from deprecated ioutil#80
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sebrandon1 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@sebrandon1: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold |
|
lets wait and check the new nftable implementation #77 |
|
closing this one. as this repo must but a d/s sync only from the upstream repo /close |
|
@SchSeba: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Sounds good! I'll take a look at the upstream. |
ioutilhas been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutilTest code modernization:
ioutil.TempDirwithos.MkdirTempfor creating temporary directories in test setup.ioutil.WriteFilewithos.WriteFilefor writing test rule files in multiple test cases. [1] [2] [3] [4]ioutilfrom the test file.Tracking issue: redhat-best-practices-for-k8s/telco-bot#52