Skip to content

OCPBUGS-78384: changed http to https for three places to reduce test false positives and false negatives #30872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Mar 18, 2026
+3 −3
Merged

OCPBUGS-78384: changed http to https for three places to reduce test false positives and false negatives #30872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/monitortests/testframework/disruptionexternalservicemonitoring/monitortest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const (
newConnectionTestName = "[sig-trt] disruption/ci-cluster-network-liveness connection/new should be available throughout the test"
reusedConnectionTestName = "[sig-trt] disruption/ci-cluster-network-liveness connection/reused should be available throughout the test"

externalServiceURL = "http://static.redhat.com/test/rhel-networkmanager.txt"
externalServiceURL = "https://static.redhat.com/test/rhel-networkmanager.txt"
)

type availability struct {
Expand Down
2 changes: 1 addition & 1 deletion test/extended/machine_config/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ func IsTwoNodeArbiter(oc *exutil.CLI) bool {

// `IsDisconnected` returns true if the cluster is a Disconnected cluster and false otherwise
func IsDisconnected(oc *exutil.CLI, nodeName string) bool {
networkStatus, _ := exutil.DebugNodeRetryWithOptionsAndChroot(oc, nodeName, "openshift-machine-config-operator", "sh", "-c", "curl -s --connect-timeout 5 http://fedoraproject.org/static/hotspot.txt &>/dev/null && echo \"Connected\" || echo \"Disconnected\"")
networkStatus, _ := exutil.DebugNodeRetryWithOptionsAndChroot(oc, nodeName, "openshift-machine-config-operator", "sh", "-c", "curl -s --connect-timeout 5 https://fedoraproject.org/static/hotspot.txt &>/dev/null && echo \"Connected\" || echo \"Disconnected\"")
if networkStatus == "Connected" {
return false
}
Expand Down
2 changes: 1 addition & 1 deletion test/extended/networking/egress_firewall.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ func sendEgressFwTraffic(f *e2e.Framework, mgmtFw *e2e.Framework, oc *exutil.CLI
// Test curl to www.redhat.com should fail
// because we don't have allow dns rule for www.redhat.com
g.By("sending traffic that does not match allow dns rule")
_, err = oc.Run("exec").Args(pod, "--", "curl", "-q", "-s", "-I", "-m5", "http://www.redhat.com").Output()
_, err = oc.Run("exec").Args(pod, "--", "curl", "-q", "-s", "-I", "-m5", "https://www.redhat.com").Output()
expectError(err)

if nodeSelectorSupport {
Expand Down