[WIP] OCPBUGS-78576: fix vgs tests flaky

[Phaow]

• Hack update the test/extended/util/image/zz_generated.txt and remove the invalid vgs test from retryTestNames(revert NO-JIRA: Allow group snapshot tests to be re-tried #30607).

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@Phaow: This pull request references Jira Issue OCPBUGS-78576, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

• Hack update the test/extended/util/image/zz_generated.txt and remove the invalid vgs test from retryTestNames.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Updates Kubernetes module dependencies in go.mod by replacing the kubernetes module mapping and adding new k8s sample component directives. Reorders test names in a retry handler slice. Updates container image references and adds new hostpathplugin image tags in a generated configuration file.

Changes

Cohort / File(s)	Summary
Dependency Management go.mod	Replaces k8s.io/kubernetes module mapping from openshift/kubernetes to a fork (Phaow/kubernetes) and adds replace directives for sample-apiserver, sample-cli-plugin, and sample-controller components.
Test Configuration pkg/test/ginkgo/retries.go	Reorders test name entries in the retryTestNames slice with no additions, removals, or behavioral changes.
Generated Image References test/extended/util/image/zz_generated.txt	Updates busybox image tag reference and adds new hostpathplugin image tag entry (v1.17.1) with corresponding digest.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.3)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can generate a title for your PR based on the changes.

Add @coderabbitai placeholder anywhere in the title of your PR and CodeRabbit will replace it with a title based on the changes in the PR. You can change the placeholder by changing the reviews.auto_title_placeholder setting.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Phaow
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS
• test/extended/util/image/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@go.mod`:
- Line 447: The go.mod replace for module k8s.io/kubernetes was changed to
github.com/Phaow/kubernetes v1.23.0-alpha..., causing a mismatch with the
OpenShift-curated Kubernetes modules; revert the replace for k8s.io/kubernetes
back to the OpenShift-managed version (the same target used by other k8s
modules, e.g., v0.0.0-20251017123720-96593f323733) or remove the replace
entirely so the dependency graph uses the openshift/staging imports, and if this
change is intentionally temporary add a brief inline comment in go.mod
explaining the reason and a rollback timeline referencing the replace of
k8s.io/kubernetes.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a373feea-30a7-4f4d-a2d1-71abe4df9931

📥 Commits

Reviewing files that changed from the base of the PR and between 085b8a0 and 1c6c73e.

⛔ Files ignored due to path filters (6)

• go.sum is excluded by !**/*.sum
• vendor/k8s.io/kubernetes/test/e2e/testing-manifests/storage-csi/external-snapshotter/volume-group-snapshots/csi-hostpath-plugin.yaml is excluded by !vendor/**, !**/vendor/**
• vendor/k8s.io/kubernetes/test/e2e/testing-manifests/storage-csi/hostpath/hostpath/csi-hostpath-plugin.yaml is excluded by !vendor/**, !**/vendor/**
• vendor/k8s.io/kubernetes/test/e2e/testing-manifests/storage-csi/mock/csi-mock-driver.yaml is excluded by !vendor/**, !**/vendor/**
• vendor/k8s.io/kubernetes/test/e2e/testing-manifests/storage-csi/mock/csi-mock-proxy.yaml is excluded by !vendor/**, !**/vendor/**
• vendor/modules.txt is excluded by !vendor/**, !**/vendor/**

📒 Files selected for processing (3)

• go.mod
• pkg/test/ginkgo/retries.go
• test/extended/util/image/zz_generated.txt

[coderabbitai]

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== k8s-related replace directives =="
awk '/^replace \(/,/^\)/ {print NR ":" $0}' go.mod | rg -n 'k8s\.io/(kubernetes|api|apimachinery|apiserver|client-go|sample-apiserver|sample-cli-plugin|sample-controller)'

echo
echo "== direct k8s module requirements =="
rg -n '^\s*k8s\.io/(api|apimachinery|apiserver|client-go|kubernetes)\s+v' go.mod

Repository: openshift/origin

Length of output: 1444

---

Replace k8s.io/kubernetes mapping back to the OpenShift-managed version.

Line 447 replaces k8s.io/kubernetes with github.com/Phaow/kubernetes v1.23.0-alpha..., which is isolated from the rest of the Kubernetes module stack. All other k8s modules (api, apimachinery, apiserver, client-go, etc.) point to github.com/openshift/kubernetes/staging/ with version v0.0.0-20251017123720-96593f323733. The outlier also introduces a version regression: v1.23.0-alpha vs. the direct requirement v1.34.1 for k8s.io/kubernetes (11+ minor versions behind).

This divergence from the curated OpenShift ecosystem creates supply-chain and compatibility risk. If temporary for flake mitigation, document the exception with a clear rollback timeline.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@go.mod` at line 447, The go.mod replace for module k8s.io/kubernetes was
changed to github.com/Phaow/kubernetes v1.23.0-alpha..., causing a mismatch with
the OpenShift-curated Kubernetes modules; revert the replace for
k8s.io/kubernetes back to the OpenShift-managed version (the same target used by
other k8s modules, e.g., v0.0.0-20251017123720-96593f323733) or remove the
replace entirely so the dependency graph uses the openshift/staging imports, and
if this change is intentionally temporary add a brief inline comment in go.mod
explaining the reason and a rollback timeline referencing the replace of
k8s.io/kubernetes.

[openshift-ci]

@Phaow: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-image-manifest-lists	1c6c73e	link	true	/test verify-image-manifest-lists

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.