CNTRLPLANE-2999:Revert PR #30746: TLS 1.3 test causing instability in 4.22

[wangke19]

Summary

This PR reverts #30746 which is causing test instability in 4.22 payloads.

Problem

Multiple test failures have been observed in periodic-ci-openshift-release-master-nightly-4.22-e2e-aws-ovn-upgrade jobs after PR #30746 was merged:

Example failures:

• https://prow.ci.openshift.org/view/gs/test-platform-results/logs/aggregated-aws-ovn-upgrade-4.21-to-4.22-ci-openshift-release-analysis-aggregator/2033742335904321536
• https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade/2033742330044878848
• https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade/2033742330229428224
• https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade/2033742330355257344

As reported in #forum-testplatform Slack channel on 2026-03-17, the payload that had the test passing 10/10 before merge is now failing. The root cause appears to be the bundled library-go dependency bump in PR #30746.

Why Revert?

PR #30746 bundled two distinct changes:

1. Test logic improvements: TLS 1.3 support, ECDSA handling, FIPS mode handling (valuable)
2. Dependency update: library-go bump + personal fork for filepath-securejoin (problematic)

The dependency changes have introduced instability and need to be separated from the test logic improvements.

What Happens Next?

A replacement PR (#30894) has been prepared that:

• ✅ Keeps all the test improvements from OCPBUGS-76334: Add TLS 1.3 (Modern profile) support to TestTLSDefaults #30746
• ✅ Removes the library-go dependency by using local crypto helpers
• ✅ Avoids the supply chain concerns of the dependency bump
• ✅ Should restore test stability by not changing unrelated dependencies

Revert Details

This revert:

• Reverts the merge commit 5c29d3af01fbee9cc0c6f748a8d2f1aac5c80a8e
• Restores the codebase to the state before PR OCPBUGS-76334: Add TLS 1.3 (Modern profile) support to TestTLSDefaults #30746
• Will allow PR [WIP]OCPBUGS-76334: Remove library-go bump from TLS 1.3 test fixes #30894 to be merged cleanly with just the test improvements

Related

• Reverted PR: OCPBUGS-76334: Add TLS 1.3 (Modern profile) support to TestTLSDefaults #30746
• Replacement PR: [WIP]OCPBUGS-76334: Remove library-go bump from TLS 1.3 test fixes #30894 (test improvements without dependency changes)
• Follow-up issue: #30890 (organization fork migration for filepath-securejoin)
• JIRA: OCPBUGS-76334
• Slack: #forum-testplatform discussion on 2026-03-17

/cc @team-technical-release

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d8353563-8e38-4c0d-8c2b-6f2a142e45dd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[stbenjam]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam, wangke19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stbenjam]

/verified by CI

[openshift-ci-robot]

@stbenjam: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[wangke19]

/retest

[openshift-ci-robot]

@wangke19: This pull request references CNTRLPLANE-2999 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

This PR reverts #30746 which is causing test instability in 4.22 payloads.

Problem

Multiple test failures have been observed in periodic-ci-openshift-release-master-nightly-4.22-e2e-aws-ovn-upgrade jobs after PR #30746 was merged:

Example failures:

• https://prow.ci.openshift.org/view/gs/test-platform-results/logs/aggregated-aws-ovn-upgrade-4.21-to-4.22-ci-openshift-release-analysis-aggregator/2033742335904321536
• https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade/2033742330044878848
• https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade/2033742330229428224
• https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade/2033742330355257344

As reported in #forum-testplatform Slack channel on 2026-03-17, the payload that had the test passing 10/10 before merge is now failing. The root cause appears to be the bundled library-go dependency bump in PR #30746.

Why Revert?

PR #30746 bundled two distinct changes:

1. Test logic improvements: TLS 1.3 support, ECDSA handling, FIPS mode handling (valuable)
2. Dependency update: library-go bump + personal fork for filepath-securejoin (problematic)

The dependency changes have introduced instability and need to be separated from the test logic improvements.

What Happens Next?

A replacement PR (#30894) has been prepared that:

• ✅ Keeps all the test improvements from OCPBUGS-76334: Add TLS 1.3 (Modern profile) support to TestTLSDefaults #30746
• ✅ Removes the library-go dependency by using local crypto helpers
• ✅ Avoids the supply chain concerns of the dependency bump
• ✅ Should restore test stability by not changing unrelated dependencies

Revert Details

This revert:

• Reverts the merge commit 5c29d3af01fbee9cc0c6f748a8d2f1aac5c80a8e
• Restores the codebase to the state before PR OCPBUGS-76334: Add TLS 1.3 (Modern profile) support to TestTLSDefaults #30746
• Will allow PR [WIP]OCPBUGS-76334: Remove library-go bump from TLS 1.3 test fixes #30894 to be merged cleanly with just the test improvements

Related

• Reverted PR: OCPBUGS-76334: Add TLS 1.3 (Modern profile) support to TestTLSDefaults #30746
• Replacement PR: [WIP]OCPBUGS-76334: Remove library-go bump from TLS 1.3 test fixes #30894 (test improvements without dependency changes)
• Follow-up issue: #30890 (organization fork migration for filepath-securejoin)
• JIRA: OCPBUGS-76334
• Slack: #forum-testplatform discussion on 2026-03-17

/cc @team-technical-release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[wangke19]

/retest

[wangke19]

/test e2e-metal-ipi-ovn-ipv6

[wangke19]

/test e2e-metal-ipi-ovn-ipv6

[stbenjam]

/override ci/prow/e2e-metal-ipi-ovn-ipv6

[openshift-ci]

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-metal-ipi-ovn-ipv6

Details

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@wangke19: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.