Skip to content

OCPNODE-4179: Migrating test case OCP-80983 from openshift-tests-private to origin#30899

Draft
Chandan9112 wants to merge 1 commit intoopenshift:mainfrom
Chandan9112:migrate-ocp-80983
Draft

OCPNODE-4179: Migrating test case OCP-80983 from openshift-tests-private to origin#30899
Chandan9112 wants to merge 1 commit intoopenshift:mainfrom
Chandan9112:migrate-ocp-80983

Conversation

@Chandan9112
Copy link

Adds automated test case OCP-80983 migrated from openshift-tests-private. The test validates:

  • All nodes are in Ready state
  • Cgroup version is v2 (cgroup2fs) on worker nodes
  • Kernel arguments include cgroupv2 parameters
  • API server rejects setting cgroupMode to v1

Here is the test case link: Polarian-80983

It passed successfully while executing on a live OCP 4.21 cluster:

./openshift-tests run-test "[sig-node] [Jira:Node/Kubelet] Kubelet, CRI-O, CPU manager should verify cgroupv2 is the default and cgroupv1 cannot be set [OCP-80983] [apigroup:config.openshift.io] [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"

Running Suite:  - /Users/cmaurya/go/src/github.com/openshift/origin
===================================================================
  Random Seed: 1773824700 - will randomize all specs
  Will run 1 of 1 specs

[sig-node] [Jira:Node/Kubelet] Kubelet, CRI-O, CPU manager should verify cgroupv2 is the default and cgroupv1 cannot be set [OCP-80983] [apigroup:config.openshift.io] [apigroup:machineconfiguration.openshift.io]
  github.com/openshift/origin/test/extended/node/node_e2e/node.go:83
    STEP: Creating a kubernetes client @ 03/18/26 14:35:04.858
  I0318 14:35:04.859488   74544 discovery.go:214] Invalidating discovery information
  I0318 14:35:04.860832 74544 framework.go:2324] [precondition-check] checking if cluster is MicroShift
  I0318 14:35:05.119305 74544 framework.go:2348] IsMicroShiftCluster: microshift-version configmap not found, not MicroShift
    STEP: Step 1: Checking all nodes are Ready @ 03/18/26 14:35:05.119
  I0318 14:35:10.785102 74544 node.go:105] All 6 nodes are Ready
    STEP: Step 2: Verifying cgroup version is v2 on a worker node @ 03/18/26 14:35:10.785
  I0318 14:35:13.700010 74544 node.go:118] Cgroup filesystem type on node ci-ln-1qq51kt-72292-6qbtc-worker-b-df8pw: Starting pod/ci-ln-1qq51kt-72292-6qbtc-worker-b-df8pw-debug-hrdcj ...
  To use host binaries, run `chroot /host`. Instead, if you need to access host namespaces, run `nsenter -a -t 1`.
  cgroup2fs

  Removing debug pod ...
    STEP: Step 3: Checking kernel arguments for cgroupv2 in rendered worker MachineConfig @ 03/18/26 14:35:13.7
  I0318 14:35:14.343939 74544 node.go:127] Rendered worker MachineConfig: rendered-worker-c7db908c3514316cff8986951195a3a2
  I0318 14:35:15.185923 74544 node.go:132] Kernel arguments: systemd.unified_cgroup_hierarchy=1 cgroup_no_v1="all"
    STEP: Step 4: Verifying that setting cgroupMode to v1 is rejected by the API server @ 03/18/26 14:35:15.186
  I0318 14:35:15.715687   74544 warnings.go:110] "Warning: unknown field \"spec.minimumKubeletVersion\""
  I0318 14:35:15.716170 74544 node.go:145] cgroupMode v1 correctly rejected with error: Node.config.openshift.io "cluster" is invalid: spec.cgroupMode: Unsupported value: "v1": supported values: "v2", ""
  • [10.881 seconds]
  ------------------------------

  Ran 1 of 1 Specs in 10.881 seconds
  SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped

Adds automated test case OCP-80983 migrated from openshift-tests-private.
The test validates:
- All nodes are in Ready state
- Cgroup version is v2 (cgroup2fs) on worker nodes
- Kernel arguments include cgroupv2 parameters
- API server rejects setting cgroupMode to v1
@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 18, 2026
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 18, 2026

@Chandan9112: This pull request references OCPNODE-4179 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Adds automated test case OCP-80983 migrated from openshift-tests-private. The test validates:

  • All nodes are in Ready state
  • Cgroup version is v2 (cgroup2fs) on worker nodes
  • Kernel arguments include cgroupv2 parameters
  • API server rejects setting cgroupMode to v1

Here is the test case link: Polarian-80983

It passed successfully while executing on a live OCP 4.21 cluster:

./openshift-tests run-test "[sig-node] [Jira:Node/Kubelet] Kubelet, CRI-O, CPU manager should verify cgroupv2 is the default and cgroupv1 cannot be set [OCP-80983] [apigroup:config.openshift.io] [apigroup:machineconfiguration.openshift.io] [Suite:openshift/conformance/parallel]"

Running Suite:  - /Users/cmaurya/go/src/github.com/openshift/origin
===================================================================
 Random Seed: 1773824700 - will randomize all specs
 Will run 1 of 1 specs

[sig-node] [Jira:Node/Kubelet] Kubelet, CRI-O, CPU manager should verify cgroupv2 is the default and cgroupv1 cannot be set [OCP-80983] [apigroup:config.openshift.io] [apigroup:machineconfiguration.openshift.io]
 github.com/openshift/origin/test/extended/node/node_e2e/node.go:83
   STEP: Creating a kubernetes client @ 03/18/26 14:35:04.858
 I0318 14:35:04.859488   74544 discovery.go:214] Invalidating discovery information
 I0318 14:35:04.860832 74544 framework.go:2324] [precondition-check] checking if cluster is MicroShift
 I0318 14:35:05.119305 74544 framework.go:2348] IsMicroShiftCluster: microshift-version configmap not found, not MicroShift
   STEP: Step 1: Checking all nodes are Ready @ 03/18/26 14:35:05.119
 I0318 14:35:10.785102 74544 node.go:105] All 6 nodes are Ready
   STEP: Step 2: Verifying cgroup version is v2 on a worker node @ 03/18/26 14:35:10.785
 I0318 14:35:13.700010 74544 node.go:118] Cgroup filesystem type on node ci-ln-1qq51kt-72292-6qbtc-worker-b-df8pw: Starting pod/ci-ln-1qq51kt-72292-6qbtc-worker-b-df8pw-debug-hrdcj ...
 To use host binaries, run `chroot /host`. Instead, if you need to access host namespaces, run `nsenter -a -t 1`.
 cgroup2fs

 Removing debug pod ...
   STEP: Step 3: Checking kernel arguments for cgroupv2 in rendered worker MachineConfig @ 03/18/26 14:35:13.7
 I0318 14:35:14.343939 74544 node.go:127] Rendered worker MachineConfig: rendered-worker-c7db908c3514316cff8986951195a3a2
 I0318 14:35:15.185923 74544 node.go:132] Kernel arguments: systemd.unified_cgroup_hierarchy=1 cgroup_no_v1="all"
   STEP: Step 4: Verifying that setting cgroupMode to v1 is rejected by the API server @ 03/18/26 14:35:15.186
 I0318 14:35:15.715687   74544 warnings.go:110] "Warning: unknown field \"spec.minimumKubeletVersion\""
 I0318 14:35:15.716170 74544 node.go:145] cgroupMode v1 correctly rejected with error: Node.config.openshift.io "cluster" is invalid: spec.cgroupMode: Unsupported value: "v1": supported values: "v2", ""
 • [10.881 seconds]
 ------------------------------

 Ran 1 of 1 Specs in 10.881 seconds
 SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 42d65c57-9dab-455d-bc63-91b7901a6393

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Chandan9112
Once this PR has been reviewed and has the lgtm label, please assign sairameshv for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants