[ossm] Fix empty string in HUB env for istio integration tests#74686
[ossm] Fix empty string in HUB env for istio integration tests#74686openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
Signed-off-by: mkralik3 <mkralik@redhat.com>
|
[REHEARSALNOTIFIER]
A total of 95 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-service-mesh-istio-release-1.27-unit pull-ci-openshift-service-mesh-istio-master-gencheck pull-ci-openshift-service-mesh-istio-master-unit pull-ci-openshift-service-mesh-istio-master-istio-integration-pilot pull-ci-openshift-service-mesh-istio-master-istio-integration-telemetry pull-ci-openshift-service-mesh-istio-master-istio-integration-security pull-ci-openshift-service-mesh-istio-master-istio-integration-ambient pull-ci-openshift-service-mesh-istio-master-istio-integration-helm pull-ci-openshift-service-mesh-istio-master-istio-integration-sail-pilot pull-ci-openshift-service-mesh-istio-master-istio-integration-sail-telemetry pull-ci-openshift-service-mesh-istio-master-istio-integration-sail-security pull-ci-openshift-service-mesh-istio-master-istio-integration-sail-ambient |
|
@mkralik3: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fjglira, mkralik3 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-sail-ambient pull-ci-openshift-service-mesh-istio-master-istio-integration-sail-telemetry pull-ci-openshift-service-mesh-istio-master-istio-integration-security pull-ci-openshift-service-mesh-istio-master-istio-integration-telemetry |
|
@mkralik3: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mkralik3: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@mkralik3: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
This PR https://github.com/openshift/release/pull/74603/changes#diff-8b512d792b5b41108d1a4b89fa8924774308ab8844678354f3a4cda26bef1879R113-R114 introduced
HUBenv, which is an empty string when it is not set.However, when it is an empty string, it causes an error in the Istio Makefile:
Added default value in the step to be sure the HUB env is always set.