Skip to content

[ossm] Fix empty string in HUB env for istio integration tests#74686

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
mkralik3:fixHub
Feb 10, 2026
Merged

[ossm] Fix empty string in HUB env for istio integration tests#74686
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
mkralik3:fixHub

Conversation

@mkralik3
Copy link
Contributor

This PR https://github.com/openshift/release/pull/74603/changes#diff-8b512d792b5b41108d1a4b89fa8924774308ab8844678354f3a4cda26bef1879R113-R114 introduced HUB env, which is an empty string when it is not set.

However, when it is an empty string, it causes an error in the Istio Makefile:

HUB ?=istio
ifeq ($(HUB),)
  $(error "HUB cannot be empty")
endif

Added default value in the step to be sure the HUB env is always set.

Signed-off-by: mkralik3 <mkralik@redhat.com>
@mkralik3 mkralik3 changed the title Fix empty string in HUB env for istio integration tests [ossm] Fix empty string in HUB env for istio integration tests Feb 10, 2026
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mkralik3: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-service-mesh-istio-master-gencheck openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-master-unit openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-master-istio-integration-pilot openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-master-istio-integration-telemetry openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-master-istio-integration-security openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-master-istio-integration-ambient openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-master-istio-integration-helm openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-master-istio-integration-sail-pilot openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-master-istio-integration-sail-telemetry openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-master-istio-integration-sail-security openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-master-istio-integration-sail-ambient openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.26-gencheck openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.26-unit openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.26-integ-helm openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.26-integ-security openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.26-integ-pilot openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.26-integ-telemetry openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.26-integ-ambient openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.24-unit openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.24-integ-helm openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.24-integ-security openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.24-integ-pilot openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.24-integ-telemetry openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.27-gencheck openshift-service-mesh/istio presubmit Registry content changed
pull-ci-openshift-service-mesh-istio-release-1.27-unit openshift-service-mesh/istio presubmit Registry content changed

A total of 95 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mkralik3
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-service-mesh-istio-release-1.27-unit pull-ci-openshift-service-mesh-istio-master-gencheck pull-ci-openshift-service-mesh-istio-master-unit pull-ci-openshift-service-mesh-istio-master-istio-integration-pilot pull-ci-openshift-service-mesh-istio-master-istio-integration-telemetry pull-ci-openshift-service-mesh-istio-master-istio-integration-security pull-ci-openshift-service-mesh-istio-master-istio-integration-ambient pull-ci-openshift-service-mesh-istio-master-istio-integration-helm pull-ci-openshift-service-mesh-istio-master-istio-integration-sail-pilot pull-ci-openshift-service-mesh-istio-master-istio-integration-sail-telemetry pull-ci-openshift-service-mesh-istio-master-istio-integration-sail-security pull-ci-openshift-service-mesh-istio-master-istio-integration-sail-ambient

@openshift-ci-robot
Copy link
Contributor

@mkralik3: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot requested review from dgn and mayleighnmyers February 10, 2026 13:58
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2026
Copy link
Contributor

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fjglira, mkralik3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkralik3
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-sail-ambient pull-ci-openshift-service-mesh-istio-master-istio-integration-sail-telemetry pull-ci-openshift-service-mesh-istio-master-istio-integration-security pull-ci-openshift-service-mesh-istio-master-istio-integration-telemetry

@openshift-ci-robot
Copy link
Contributor

@mkralik3: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2026

@mkralik3: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mkralik3
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@mkralik3: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 10, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit b31d0ee into openshift:main Feb 10, 2026
22 checks passed
gpei pushed a commit to gpei/release that referenced this pull request Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants