OCPBUGS-78110: [release-4.12] hermetic 4.12 by fgallott · Pull Request #744 · openshift/router

fgallott · 2026-03-02T15:25:15Z

same as #743

openshift-ci-robot · 2026-03-02T15:25:32Z

@fgallott: This pull request explicitly references no jira issue.

Details

In response to this:

same as #743

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

fgallott · 2026-03-10T08:22:17Z

/jira cherrypick OCPBUGS-78109

openshift-ci-robot · 2026-03-10T08:22:27Z

@fgallott: Jira Issue OCPBUGS-78109 has been cloned as Jira Issue OCPBUGS-78110. Will retitle bug to link to clone.
/retitle OCPBUGS-78110: [release-4.12] NO-JIRA: hermetic 4.12

Details

In response to this:

/jira cherrypick OCPBUGS-78109

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-10T08:22:35Z

@fgallott: This pull request references Jira Issue OCPBUGS-78110, which is invalid:

expected dependent Jira Issue OCPBUGS-78109 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

same as #743

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-03-12T11:42:22Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7b6b16ab-490a-44ed-aa54-f3c3d8554866

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

fgallott · 2026-03-13T17:05:05Z

/retest-required

alebedev87 · 2026-03-17T15:18:55Z

/retitle OCPBUGS-78110: [release-4.12] hermetic 4.12

alebedev87 · 2026-03-17T15:19:47Z

Can you please 1) squash/fixup commits into a single one, 2) reference Jira bug in the commit message too, 3) explain more why the change is needed for hermetic build in the commit message too?

Hermetic builds require that all dependencies are vendored and that the vendor directory is fully consistent with go.mod. The build was failing with: Error: PackageRejected: The content of the vendor directory is not consistent with go.mod. This was caused by a missing file (vendor/github.com/getsentry/ raven-go/Dockerfile.test) which was likely excluded by a .gitignore rule matching "Dockerfile*". Running `go mod vendor` restores this file, and it must be committed with `git add --force` to satisfy the hermetic build's vendor consistency check. Additionally, test certificates in validation_test.go and plugin_test.go were regenerated because they had expired, which caused unit test failures. rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED

fgallott · 2026-03-17T15:38:02Z

Can you please 1) squash/fixup commits into a single one, 2) reference Jira bug in the commit message too, 3) explain more why the change is needed for hermetic build in the commit message too?

done

gcs278 · 2026-03-18T15:08:07Z

/assign @alebedev87

fgallott · 2026-03-24T20:00:57Z

/retest-required

fgallott · 2026-03-31T13:35:24Z

@alebedev87 may you have a look at this one? the failing tests are not related to this change

openshift-ci · 2026-04-08T14:27:10Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jupierce · 2026-04-08T14:28:18Z

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-upgrade

openshift-ci · 2026-04-08T14:28:35Z

@jupierce: Overrode contexts on behalf of jupierce: ci/prow/e2e-aws-serial, ci/prow/e2e-upgrade

Details

In response to this:

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-04-08T14:28:41Z

@fgallott: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-04-08T14:32:10Z

@fgallott: Jira Issue Verification Checks: Jira Issue OCPBUGS-78110
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-78110 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

same as #743

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-04-09T08:18:21Z

Fix included in accepted release 4.12.0-0.nightly-2026-04-09-020127

fgallott changed the title ~~hermetic 4.12~~ [release-4.12] NO-JIRA: hermetic 4.12 Mar 2, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 2, 2026

openshift-ci bot requested review from alebedev87 and frobware March 2, 2026 15:25

openshift-ci bot changed the title ~~[release-4.12] NO-JIRA: hermetic 4.12~~ OCPBUGS-78110: [release-4.12] NO-JIRA: hermetic 4.12 Mar 10, 2026

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 10, 2026

openshift-ci bot changed the title ~~OCPBUGS-78110: [release-4.12] NO-JIRA: hermetic 4.12~~ OCPBUGS-78110: [release-4.12] hermetic 4.12 Mar 17, 2026

fgallott force-pushed the hermetic-4.12 branch from a240df8 to 1c3349c Compare March 17, 2026 15:37

openshift-ci bot assigned alebedev87 Mar 18, 2026

jupierce added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 8, 2026

openshift-ci bot assigned lihongan, melvinjoseph86, rhamini3 and ShudiLi Apr 8, 2026

openshift-merge-bot bot merged commit 186bf22 into openshift:release-4.12 Apr 8, 2026
8 checks passed

fgallott deleted the hermetic-4.12 branch April 8, 2026 14:32

fgallott mentioned this pull request Apr 9, 2026

hermetic 4.12 openshift-eng/ocp-build-data#9934

Merged

Conversation

fgallott commented Mar 2, 2026

Uh oh!

openshift-ci-robot commented Mar 2, 2026

Uh oh!

fgallott commented Mar 10, 2026

Uh oh!

openshift-ci-robot commented Mar 10, 2026

Uh oh!

openshift-ci-robot commented Mar 10, 2026

Uh oh!

coderabbitai bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

fgallott commented Mar 13, 2026

Uh oh!

alebedev87 commented Mar 17, 2026

Uh oh!

alebedev87 commented Mar 17, 2026

Uh oh!

fgallott commented Mar 17, 2026

Uh oh!

gcs278 commented Mar 18, 2026

Uh oh!

fgallott commented Mar 24, 2026

Uh oh!

fgallott commented Mar 31, 2026

Uh oh!

openshift-ci bot commented Apr 8, 2026

Uh oh!

jupierce commented Apr 8, 2026

Uh oh!

openshift-ci bot commented Apr 8, 2026

Uh oh!

openshift-ci bot commented Apr 8, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 8, 2026

Uh oh!

openshift-merge-robot commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

coderabbitai bot commented Mar 12, 2026 •

edited

Loading