Skip to content

COO-1668: fix: Console crash on displaying alerting rules#204

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
alanconway:coo-1668-resize-error
Mar 4, 2026
Merged

COO-1668: fix: Console crash on displaying alerting rules#204
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
alanconway:coo-1668-resize-error

Conversation

@alanconway
Copy link
Contributor

@alanconway alanconway commented Mar 3, 2026

The ResizeObserver error is benign and only shows up in development.
Added a filter in the webpack configuration.

/cherrypick release-0.4

Summary by CodeRabbit

  • Bug Fixes
    • Suppressed a non-critical ResizeObserver error notification from displaying in the development overlay while maintaining visibility of other runtime errors.

The ResizeObserver error is benign and only shows up in development.
Added a filter in the webpack configuration.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 3, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 3, 2026

@alanconway: This pull request references COO-1668 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

The ResizeObserver error is benign and only shows up in development.
Added a filter in the webpack configuration.

/cherrypick release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 0428701 and cb5da28.

📒 Files selected for processing (1)
  • web/webpack.config.ts

Walkthrough

Adds runtime error suppression in the Webpack dev server client overlay configuration for the "ResizeObserver loop completed with undelivered notifications." message, while preserving default error display behavior for all other runtime errors in web/webpack.config.ts.

Changes

Cohort / File(s) Summary
Webpack Dev Server Configuration
web/webpack.config.ts
Introduces error overlay handler that suppresses ResizeObserver notification warnings during development while maintaining display of other runtime errors.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title references fixing a 'console crash on displaying alerting rules,' but the actual change only suppresses a benign ResizeObserver error in webpack dev server configuration without addressing any crash. Revise the title to accurately reflect the change, such as 'Suppress ResizeObserver error in webpack dev server' or similar, to match the actual implementation.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed PR modifies only web/webpack.config.ts (webpack configuration), not test files. No test names or dynamic test identifiers are introduced.
Test Structure And Quality ✅ Passed The custom check for test structure is not applicable. This PR modifies only webpack configuration with no test code changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 3, 2026

@alanconway: This pull request references COO-1668 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

The ResizeObserver error is benign and only shows up in development.
Added a filter in the webpack configuration.

/cherrypick release-0.4

Summary by CodeRabbit

  • Bug Fixes
  • Suppressed a non-critical ResizeObserver error notification from displaying in the development overlay while maintaining visibility of other runtime errors.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from shwetaap and zhuje March 3, 2026 21:36
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2026

@alanconway: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@PeterYurkovich
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,alanconway]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anpingli
Copy link
Contributor

anpingli commented Mar 4, 2026

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 4, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 4, 2026

@alanconway: This pull request references COO-1668 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

The ResizeObserver error is benign and only shows up in development.
Added a filter in the webpack configuration.

/cherrypick release-0.4

Summary by CodeRabbit

  • Bug Fixes
  • Suppressed a non-critical ResizeObserver error notification from displaying in the development overlay while maintaining visibility of other runtime errors.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 50a59a5 into openshift:main Mar 4, 2026
6 checks passed
@openshift-cherrypick-robot

@alanconway: new pull request created: #206

Details

In response to this:

The ResizeObserver error is benign and only shows up in development.
Added a filter in the webpack configuration.

/cherrypick release-0.4

Summary by CodeRabbit

  • Bug Fixes
  • Suppressed a non-critical ResizeObserver error notification from displaying in the development overlay while maintaining visibility of other runtime errors.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants