Open
Conversation
jkua
reviewed
Oct 23, 2025
|
User report here - thanks for this! I've been using the Python client for the last few days. It mostly works, but I occasionally get: Certainly, |
Author
|
I've pushed a fix now, to the same branch. |
Author
|
Just FYI, it seems like the maintainers of this repo don't respond to many pull requests, so I don't expect this to be merged. I've made a fork with this and several other improvements here: https://github.com/mdavis-xyz/opensky-api/tree/fork Install it with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few things.
None. This is a breaking change I suppose (though not covered by unit tests, I think). But returning None instead of an error makes this library extremely difficult to use. see Calling example returns None #72requests.Session(), so that the TLS and TCP connection is re-used across multiple requests, for performance reasons, and to simplify authentication handlingurl_postargument to an internal function, because it's for a GET request, so the name was misleadingpython test*.py(At first I thought the tests were passing, then I realised that they weren't actually being run.)Note that all the
get_statetests fail for me, even on the master branch. I think I don't have sufficiently privileged auth credentials.And now I'm getting 503 errors for most calls, so I can't be sure this is correct. That's why I've marked this PR as Draft. (I'm still uploading it so you can see, because I might not have time to get back to this for another week.)