maven: switch to maven.compiler.release#88
Merged
bgilbert merged 2 commits intoopenslide:mainfrom Jan 26, 2025
Merged
Conversation
Build with --release instead of -source and -target, to ensure we use the
correct language rules and system classes. Fixes build warning on
Java > 22:
Warning: location of system modules is not set in conjunction with -source 22
not setting the location of system modules may lead to class files that cannot run on JDK 22
--release 22 is recommended instead of -source 22 -target 22 because it sets the location of system modules automatically
Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
It should be safe to generate the dist jar with the latest Java, but just to be sure, continue using Java 22. setup-java doesn't provide an alias for the latest Java release, so specify it by version. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
Member
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build with
--releaseinstead of-sourceand-target, to ensure we use the correct language rules and system classes. Fixes build warning on Java > 22:Run CI on both the minimum supported and latest Java.