[フォーム] 選択肢の末尾に全学空白があると、入力エラー時に選択したものが外れるバグ修正#2373
Open
akagane99 wants to merge 5 commits intoopensource-workshop:masterfrom
Open
[フォーム] 選択肢の末尾に全学空白があると、入力エラー時に選択したものが外れるバグ修正#2373akagane99 wants to merge 5 commits intoopensource-workshop:masterfrom
akagane99 wants to merge 5 commits intoopensource-workshop:masterfrom
Conversation
masaton0216
requested changes
Feb 25, 2026
Contributor
masaton0216
left a comment
There was a problem hiding this comment.
ご無沙汰しております&ご対応ありがとうございます。
今のままでも問題ないように見受けられますが、いくつかコメントさせて頂きました。
Contributor
Author
|
@masaton0216 |
masaton0216
approved these changes
Feb 26, 2026
Contributor
masaton0216
left a comment
There was a problem hiding this comment.
ご対応ありがとうございます。LGTMでございます。
訳あってマージがちょっと保留状態(最大で3月中旬頃まで)となっている為、マージは少々お待ちください。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
前述のバグ修正です。
レビュー完了希望日
急ぎません
関連Pull requests/Issues
概要に記載
参考
なし
DB変更の有無
なし
チェックリスト