Add hook to multi-NS VA to update container images in openstack2 NS#732
Merged
softwarefactory-project-zuul[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom Apr 6, 2026
Conversation
Contributor
Author
|
This PR, openstack-k8s-operators/ci-framework#3819 and a hidden internal PR fixed the multi-namespace VA job in my testing. |
vakwetu
added a commit
to vakwetu/architecture
that referenced
this pull request
Apr 1, 2026
… in openstack2 NS Mirrors architecture PR openstack-k8s-operators#732 which adds this for the multi-namespace scenario. Runs after the leaf control plane is deployed and ready, before CA bundle and federation configuration hooks. Reuses the shared playbooks/multi-namespace/ns2_update_containers.yaml playbook from ci-framework rather than duplicating it. Depends-On: openstack-k8s-operators/ci-framework#3819 Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Ade Lee <alee@redhat.com> Made-with: Cursor
…penstack2 The update_containers role only runs once during deploy-architecture, targeting the default openstack namespace. In a multi-namespace setup this leaves the OpenStackVersion CR in openstack2 without customContainerImages, causing EDPM nodes in that namespace to use default images. Add a post_stage_run hook on the control-plane2 stage so that after both control planes are Ready, the update_containers role is invoked for the openstack2 namespace before EDPM nodesets are created. Made-with: Cursor
ec3dadb to
96e20db
Compare
Contributor
Author
|
Testing successful. Ready for merge. |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Apr 6, 2026
…in openstack2 NS Mirrors architecture PR #732 which adds this for the multi-namespace scenario. Runs before the leaf control plane is deployed so that fresh deploys start with the correct images without a restart, and re-runs wait for the central OSCP to settle before proceeding. Reuses the shared playbooks/multi-namespace/ns2_update_containers.yaml playbook from ci-framework rather than duplicating it. Passes the required cifmw_update_containers_namespace, cifmw_update_containers_metadata, and cifmw_update_containers extra_vars so the update_containers role runs with the correct context. Co-Authored-By: Claude (cursor) <noreply@anthropic.com> Signed-off-by: Ade Lee <alee@redhat.com>
softwarefactory-project-zuul bot
added a commit
that referenced
this pull request
Apr 6, 2026
[multi-namespace-skmo] Add pre-stage hook to update container images in openstack2 NS Mirrors architecture PR #732 which adds this for the multi-namespace scenario. Runs after the leaf control plane is deployed and ready, before CA bundle and federation configuration hooks. Reuses the shared playbooks/multi-namespace/ns2_update_containers.yaml playbook from ci-framework rather than duplicating it. Depends-On: openstack-k8s-operators/ci-framework#3819 Made-with: Cursor Reviewed-by: Andrew Bays <andrew.bays@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, fultonj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
Build succeeded (gate pipeline). ✔️ noop SUCCESS in 0s |
86d8232
into
openstack-k8s-operators:main
9 checks passed
eduolivares
pushed a commit
to eduolivares/architecture
that referenced
this pull request
Apr 9, 2026
…in openstack2 NS Mirrors architecture PR openstack-k8s-operators#732 which adds this for the multi-namespace scenario. Runs before the leaf control plane is deployed so that fresh deploys start with the correct images without a restart, and re-runs wait for the central OSCP to settle before proceeding. Reuses the shared playbooks/multi-namespace/ns2_update_containers.yaml playbook from ci-framework rather than duplicating it. Passes the required cifmw_update_containers_namespace, cifmw_update_containers_metadata, and cifmw_update_containers extra_vars so the update_containers role runs with the correct context. Co-Authored-By: Claude (cursor) <noreply@anthropic.com> Signed-off-by: Ade Lee <alee@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update_containers role only runs once during deploy-architecture, targeting the default openstack namespace. In a multi-namespace setup this leaves the OpenStackVersion CR in openstack2 without customContainerImages, causing EDPM nodes in that namespace to use default images.
Add a pre_stage_run hook on the control-plane2 stage so that before both control planes are deployed, the update_containers role is invoked for the openstack2 namespace to update the default images in the
OpenStackVersion.Made-with: Cursor/Claude
Depends-On: openstack-k8s-operators/ci-framework#3819