Skip to content

Add hook to multi-NS VA to update container images in openstack2 NS#732

Merged
softwarefactory-project-zuul[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
abays:multi-ns-update-containers-openstack2
Apr 6, 2026
Merged

Add hook to multi-NS VA to update container images in openstack2 NS#732
softwarefactory-project-zuul[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
abays:multi-ns-update-containers-openstack2

Conversation

@abays
Copy link
Copy Markdown
Contributor

@abays abays commented Mar 31, 2026

The update_containers role only runs once during deploy-architecture, targeting the default openstack namespace. In a multi-namespace setup this leaves the OpenStackVersion CR in openstack2 without customContainerImages, causing EDPM nodes in that namespace to use default images.

Add a pre_stage_run hook on the control-plane2 stage so that before both control planes are deployed, the update_containers role is invoked for the openstack2 namespace to update the default images in the OpenStackVersion.

Made-with: Cursor/Claude

Depends-On: openstack-k8s-operators/ci-framework#3819

@abays
Copy link
Copy Markdown
Contributor Author

abays commented Mar 31, 2026

This PR, openstack-k8s-operators/ci-framework#3819 and a hidden internal PR fixed the multi-namespace VA job in my testing.

@abays abays requested a review from kstrenkova April 1, 2026 09:25
vakwetu added a commit to vakwetu/architecture that referenced this pull request Apr 1, 2026
… in openstack2 NS

Mirrors architecture PR openstack-k8s-operators#732 which adds this for the multi-namespace
scenario. Runs after the leaf control plane is deployed and ready,
before CA bundle and federation configuration hooks.

Reuses the shared playbooks/multi-namespace/ns2_update_containers.yaml
playbook from ci-framework rather than duplicating it.

Depends-On: openstack-k8s-operators/ci-framework#3819

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Ade Lee <alee@redhat.com>
Made-with: Cursor
…penstack2

The update_containers role only runs once during deploy-architecture,
targeting the default openstack namespace. In a multi-namespace setup
this leaves the OpenStackVersion CR in openstack2 without
customContainerImages, causing EDPM nodes in that namespace to use
default images.

Add a post_stage_run hook on the control-plane2 stage so that after
both control planes are Ready, the update_containers role is invoked
for the openstack2 namespace before EDPM nodesets are created.

Made-with: Cursor
@abays abays force-pushed the multi-ns-update-containers-openstack2 branch from ec3dadb to 96e20db Compare April 3, 2026 13:36
@abays abays added the testing-complete Testing is completed and ready for final reviews label Apr 6, 2026
@abays
Copy link
Copy Markdown
Contributor Author

abays commented Apr 6, 2026

Testing successful. Ready for merge.

softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 6, 2026
…in openstack2 NS

Mirrors architecture PR #732 which adds this for the multi-namespace
scenario. Runs before the leaf control plane is deployed so that fresh
deploys start with the correct images without a restart, and re-runs
wait for the central OSCP to settle before proceeding.

Reuses the shared playbooks/multi-namespace/ns2_update_containers.yaml
playbook from ci-framework rather than duplicating it.

Passes the required cifmw_update_containers_namespace,
cifmw_update_containers_metadata, and cifmw_update_containers extra_vars
so the update_containers role runs with the correct context.

Co-Authored-By: Claude (cursor) <noreply@anthropic.com>
Signed-off-by: Ade Lee <alee@redhat.com>
softwarefactory-project-zuul bot added a commit that referenced this pull request Apr 6, 2026
[multi-namespace-skmo] Add pre-stage hook to update container images in openstack2 NS

Mirrors architecture PR #732 which adds this for the multi-namespace scenario. Runs after the leaf control plane is deployed and ready, before CA bundle and federation configuration hooks.
Reuses the shared playbooks/multi-namespace/ns2_update_containers.yaml playbook from ci-framework rather than duplicating it.
Depends-On: openstack-k8s-operators/ci-framework#3819
Made-with: Cursor

Reviewed-by: Andrew Bays <andrew.bays@gmail.com>
Copy link
Copy Markdown
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, fultonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link
Copy Markdown
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bb284c87b23c4267b9a86bbc969d8dc7

✔️ noop SUCCESS in 0s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 86d8232 into openstack-k8s-operators:main Apr 6, 2026
9 checks passed
eduolivares pushed a commit to eduolivares/architecture that referenced this pull request Apr 9, 2026
…in openstack2 NS

Mirrors architecture PR openstack-k8s-operators#732 which adds this for the multi-namespace
scenario. Runs before the leaf control plane is deployed so that fresh
deploys start with the correct images without a restart, and re-runs
wait for the central OSCP to settle before proceeding.

Reuses the shared playbooks/multi-namespace/ns2_update_containers.yaml
playbook from ci-framework rather than duplicating it.

Passes the required cifmw_update_containers_namespace,
cifmw_update_containers_metadata, and cifmw_update_containers extra_vars
so the update_containers role runs with the correct context.

Co-Authored-By: Claude (cursor) <noreply@anthropic.com>
Signed-off-by: Ade Lee <alee@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm testing-complete Testing is completed and ready for final reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants