Fix task name truncation in ci_script plugin: use rstrip instead of rsplit#3641
Conversation
ciecierski
force-pushed
the
ci_script_improvment
branch
from
678a4cc to
6a47f8e
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6199d890a3d146a8bfc89d15b79823cd ❌ openstack-k8s-operators-content-provider FAILURE in 6m 23s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3a7eff0065194ae6aa9f147ed9d3482b ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 02m 53s |
ciecierski
force-pushed
the
ci_script_improvment
branch
from
6a47f8e to
c9dfefe
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b9d3c04e5a5642c7948ced3d85aeedcc ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 39m 09s |
|
This PR is stale because it has been for over 15 days with no activity. |
ciecierski
force-pushed
the
ci_script_improvment
branch
from
c9dfefe to
261704c
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b358a0d2731148a9817a5a434c7766c6 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 03s |
ciecierski
force-pushed
the
ci_script_improvment
branch
from
261704c to
5aeface
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8a885587ce204ad9834cc57377ebeeff ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 11m 51s |
ciecierski
force-pushed
the
ci_script_improvment
branch
from
5aeface to
3a21973
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5833e105fef94b158f7f81269d142fd2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 31m 03s |
…split
Using rsplit("_", 1)[0] dropped the last segment when there was no
trailing underscore (e.g. for short ansible task names like "Deploy ceph"
became "deploy").
Use rstrip("_") so we only remove a trailing underscore at the end of string.
Update the script integration test expectations: ci_script_* artifact and log
paths now use the full normalized task-name slug (e.g. ..._failing_script,
..._debug_enabled, ..._chdir_option). Refresh SHA1 checksums for the generated
.sh wrappers and for the chdir task log; other log checksums are unchanged.
Signed-off-by: Mikołaj Ciecierski <mikolaj.ciecierski@redhat.com>
ciecierski
force-pushed
the
ci_script_improvment
branch
from
3a21973 to
0258364
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brjackma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 56d8bb6
into
openstack-k8s-operators:main
2 participants
Using rsplit("_", 1)[0] dropped the last segment when there was no trailing underscore (e.g. for short ansible task names like "Deploy ceph" became "deploy").
Use rstrip("_") so we only remove a trailing underscore at the end of string.
Update the script integration test expectations: ci_script_* artifact and log
paths now use the full normalized task-name slug (e.g. ..._failing_script,
..._debug_enabled, ..._chdir_option). Refresh SHA1 checksums for the generated
.sh wrappers and for the chdir task log; other log checksums are unchanged.
Signed-off-by: Mikołaj Ciecierski mikolaj.ciecierski@redhat.com