[skmo] Follow-up refactoring: replace remaining shell tasks with k8s.core#3826
[skmo] Follow-up refactoring: replace remaining shell tasks with k8s.core#3826vakwetu wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…kubernetes.core Address non-blocking review suggestions from evallesp and fultonj on ci-framework PR openstack-k8s-operators#3766. In hooks/playbooks/skmo/prepare-leaf.yaml: - Replace the 'Ensure leaf osp-secret exists' and 'Read leaf admin password' shell tasks with a single set_fact that parses the osp-secrets.env file directly using regex_findall. Pre-creating the secret in the leaf namespace is unnecessary because kustomize already creates it there during stage 6; the hook only ever needed the password value itself. - Replace the 'Create TransportURL CR' and 'Wait for TransportURL' shell tasks with kubernetes.core.k8s (idempotent apply) and kubernetes.core.k8s_info with retries/until (condition polling). In roles/federation/tasks/hook_controlplane_config.yml: - Remove the redundant trailing | default('custom-ca-certs', true) from the _federation_ca_bundle_secret_name fact. The preceding cifmw_custom_ca_certs_secret_name | default('custom-ca-certs', true) already guarantees a non-empty value, making the outer default a no-op. Signed-off-by: Ade Lee <alee@redhat.com> Co-Authored-By: Claude <noreply@anthropic.com>
6387588 to
545500b
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/aacfe7e6fbcd456ba53e88590b750d46 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 12m 53s |
Address non-blocking review suggestions from evallesp and fultonj on ci-framework PR #3766.
In hooks/playbooks/skmo/prepare-leaf.yaml:
In roles/federation/tasks/hook_controlplane_config.yml: