Add support for cinder-manage online data migrations#624
Open
fmount wants to merge 3 commits intoopenstack-k8s-operators:mainfrom
Open
Add support for cinder-manage online data migrations#624fmount wants to merge 3 commits intoopenstack-k8s-operators:mainfrom
fmount wants to merge 3 commits intoopenstack-k8s-operators:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/62ff833b1f554bd99cebdadb07f49999 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 36s |
Enhanced the job interface to support multiple cinder-manage commands: - Added generic CinderManageJob() function with job type parameter - Implemented OnlineDataMigrationsJob() for upgrade scenarios - Maintained backward compatibility with existing DbSyncJob() - Added proper command routing and configuration logic This enables running cinder-manage db online_data_migrations during upgrades as documented in upstream OpenStack upgrade procedure [1]. [1] https://docs.openstack.org/cinder/latest/admin/upgrades.html Co-Authored-By: Claude <noreply@anthropic.com>
…job.go Simplified cinder-manage job execution by removing unnecessary kolla layer: - Updated DBSyncCommand to use direct cinder-manage command - Removed kolla-specific environment variables (KOLLA_CONFIG_STRATEGY, KOLLA_BOOTSTRAP) - Eliminated kolla config.json mount (/var/lib/kolla/config_files/config.json) - Renamed dbsync.go to job.go to better reflect multi-command purpose - Maintained existing volume structure with filtered config items Both dbsync and online_data_migrations now execute cinder-manage commands directly without kolla abstraction, simplifying execution and reducing dependencies while preserving backward compatibility. Co-Authored-By: Claude <noreply@anthropic.com>
Integrate online data migrations execution in cinder controller and update envTests to verify the new condition. This enables cinder-manage db online_data_migrations to run automatically during cinder deployment initialization, supporting proper OpenStack upgrade procedures as documented upstream. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the existing job interface to support multiple
cinder-managecommands.The main purpose of this patch is to introduce the ability to run
online_data_migration, required in the upgrade context and described in the upstream documentation [1].For this reason, this patch:
CinderManageJob()function with job type parameterOnlineDataMigrationsJob(), useful for upgrade scenariosDbSyncJob()Jira: OSPRH-1559
[1] https://docs.openstack.org/cinder/latest/admin/upgrades.html