Skip to content

[b/r] Add backup/restore labels to BIND9 zone data PVCs#442

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
stuggi:backup_restore
Apr 13, 2026
Merged

[b/r] Add backup/restore labels to BIND9 zone data PVCs#442
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
stuggi:backup_restore

Conversation

@stuggi
Copy link
Copy Markdown
Contributor

@stuggi stuggi commented Apr 1, 2026

Add backup and restore labels to the BIND9 StatefulSet VolumeClaimTemplates for new environments, and reconcile labels on existing PVCs for upgrades. DNS zone data reconstruction from the database can take significant time and cause request errors, so including BIND9 PVCs in backup/restore avoids this.

Uses backup.EnsureBackupLabels from lib-common for PVC label reconciliation on upgrades.

Jira: OSPRH-22912
Jira: OSPRH-22913
Jira: OSPRH-27012

Depends-On: openstack-k8s-operators/lib-common#680

@openshift-ci openshift-ci bot requested review from abays and dprince April 1, 2026 06:06
@openshift-ci openshift-ci bot added the approved label Apr 1, 2026
@stuggi stuggi force-pushed the backup_restore branch 3 times, most recently from 1540ed1 to db40a9b Compare April 10, 2026 12:18
@stuggi
Copy link
Copy Markdown
Contributor Author

stuggi commented Apr 12, 2026

/retest

@stuggi stuggi force-pushed the backup_restore branch 2 times, most recently from 301fa83 to 6294919 Compare April 13, 2026 12:24
@stuggi stuggi requested a review from beagles April 13, 2026 15:25
Comment thread internal/controller/designatebackendbind9_controller.go
Add backup and restore labels to the BIND9 StatefulSet
VolumeClaimTemplates for new environments, and reconcile labels on
existing PVCs for upgrades. DNS zone data reconstruction from the
database can take significant time and cause request errors, so
including BIND9 PVCs in backup/restore avoids this.

Uses backup.EnsureBackupLabels from lib-common for PVC label
reconciliation on upgrades.

Jira: OSPRH-22912
Jira: OSPRH-22913

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Copy link
Copy Markdown
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 90dac8d into openstack-k8s-operators:main Apr 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants