Cleanup orphan certificates when nodes are removed from NodeSet #1792
Conversation
|
/test functional |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a92c233d21144e86ad9d6b51329980ab ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 19m 38s |
|
/retest-required |
|
recheck |
When a node is removed from a DataPlane NodeSet, the TLS certificates created for that node were not being cleaned up, leaving orphan Certificate resources in the cluster. This adds a cleanupStaleCertificates function that runs at the beginning of EnsureTLSCerts to delete certificates for nodes that no longer exist in the NodeSet. It uses the allHostnames map (which reflects current nodes) to identify stale certificates by comparing against the hostname label on existing Certificate CRs. Jira: OSPRH-26077 Signed-off-by: rabi <ramishra@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rabi, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test openstack-operator-build-deploy-kuttl-4-18 |
1 similar comment
|
/test openstack-operator-build-deploy-kuttl-4-18 |
|
/test functional |
5 similar comments
|
/test functional |
|
/test functional |
|
/test functional |
|
/test functional |
|
/test functional |
|
@rabi: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
the cluster seems to overloaded. tuning envtest #1798 helped. need to rebase when landed |
4 participants
When a node is removed from a DataPlane NodeSet, the TLS certificates created for that node were not being cleaned up, leaving orphan Certificate resources in the cluster.
This adds a cleanupStaleCertificates function that runs at the beginning of EnsureTLSCerts to delete certificates for nodes that no longer exist in the NodeSet. It uses the allHostnames map (which reflects current nodes) to identify stale certificates by comparing against the hostname label on existing Certificate CRs.
Jira: OSPRH-26077