[ovndbcluster] Allow config changes without pod restarts

[karelyatin]

Currently for any config change pod get's restart which we don't need for configs like:-

• ElectionTimer
• InactivityProbe
• LogLevel

Deprecated probeIntervalToActive config option as
that is not relevant only for active/standby db clusters which we are not using here.

Also using db directories(as persistent) for OVN_RUNDIR, so we can use them in job pods to do the config changes.

Resolves: #OSPRH-27985
Assisted-By: Claude

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f021bdefc9c34b7f823ff7d1c795d42d

❌ openstack-k8s-operators-content-provider FAILURE in 6m 08s
⚠️ ovn-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

[karelyatin]

recheck trunkrdo

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/75cf967375fd46b89297dcb96d40bb5b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 27m 28s
❌ ovn-operator-tempest-multinode FAILURE in 1h 08m 50s

[averdagu]

So far code looks good to me, I'll test this tomorrow

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c94c02f79a5c4014815fb1deaf9bf96e

✔️ openstack-k8s-operators-content-provider SUCCESS in 42m 50s
❌ ovn-operator-tempest-multinode FAILURE in 26m 02s

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8c894ca3175b4071805370bdeb6d6e45

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 27s
❌ ovn-operator-tempest-multinode FAILURE in 1h 09m 58s

[averdagu]

Adding comment here instead of code as I don't know the best way to handle this, but we need to sanitize the input given by the user.
I tested out by adding "logLevel: debug" but ovn-appctl only accepts "dbg".
We need to check the input either on the CR, or in the script (though doing it in the script may seem all went fine but log level was not changed)

[karelyatin]

Adding comment here instead of code as I don't know the best way to handle this, but we need to sanitize the input given by the user. I tested out by adding "logLevel: debug" but ovn-appctl only accepts "dbg". We need to check the input either on the CR, or in the script (though doing it in the script may seem all went fine but log level was not changed)

yes i noticed that too but since it was not specific to this change i didn't touched api for this. So we can take that as follow up too

[averdagu]

Adding comment here instead of code as I don't know the best way to handle this, but we need to sanitize the input given by the user. I tested out by adding "logLevel: debug" but ovn-appctl only accepts "dbg". We need to check the input either on the CR, or in the script (though doing it in the script may seem all went fine but log level was not changed)

yes i noticed that too but since it was not specific to this change i didn't touched api for this. So we can take that as follow up too

For the record, created an issue for this problem that I plan to work it on :)

[averdagu]

Looks all good to me

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karelyatin, slawqo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [karelyatin,slawqo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[karelyatin]

/test ovn-operator-build-deploy-kuttl
must gather fail

[karelyatin]

/test ovn-operator-build-deploy-kuttl
gather failure last

[karelyatin]

/cherry-pick 18.0-fr5

[openshift-cherrypick-robot]

@karelyatin: new pull request created: #555

Details

In response to this:

/cherry-pick 18.0-fr5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.