-
Notifications
You must be signed in to change notification settings - Fork 2
feat: DSPX-2416 add subject mapping guide #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marythought
wants to merge
17
commits into
main
Choose a base branch
from
feat/dspx-2416
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
f2bd649
feat: DSPX-2416 add subject mapping deep dive to new Guides section
marythought 58336cf
code review
marythought 84e313d
fix vale ci issues
marythought b428af7
go back to previous example
marythought 5526bf0
updates to agents file
marythought 13761c3
npm run update-vendored-yaml
marythought 231aacd
Merge branch 'main' into feat/dspx-2416
jp-ayyappan 6e98175
Merge branch 'main' into feat/dspx-2416
marythought 80297e9
Merge branch 'main' into feat/dspx-2416
marythought 7e17278
Merge branch 'main' into feat/dspx-2416
marythought 930f394
fix(subject-mapping-guide): address code review — correct hallucinate…
marythought d06dc61
docs(subject-mapping-guide): add content from community discussions #…
marythought aa8fe58
fix(subject-mapping-guide): use [] selector for array claims, explain…
marythought 47f6ae8
fix(vale): repair broken regex patterns and add missing vocab terms
marythought d688d4d
docs(subject-mapping-guide): improve architecture section readability…
marythought a5f49db
docs(subject-mapping-guide): improve step-by-step UX — explain operat…
marythought 7bef8ce
docs(subject-mapping-guide): address step-by-step UX friction points
marythought File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| Docusaurus | ||
| [Oo]tdfctl | ||
| API | ||
| (?i:tdf) | ||
| [Nn]amespace | ||
| Keycloak | ||
| Virtru | ||
| SDK | ||
| IdP | ||
| NPE | ||
| PE | ||
| FQN | ||
| JWT | ||
| proto | ||
| Postgres | ||
| ECDSA | ||
| [Nn]ano | ||
| Podman | ||
| assertation | ||
| [Dd]issem | ||
| JavaScript | ||
| Autoconfigure | ||
| requester('s)? | ||
| rewraps? | ||
| CI | ||
| [Ss]hellcheck | ||
| Okta |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "label": "Guides", | ||
| "position": 3, | ||
| "link": { | ||
| "type": "generated-index", | ||
| "description": "Comprehensive guides and tutorials for implementing OpenTDF features." | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the best way to do this, but we will want to make it clearer that Subject Mappings are actually logically checking the Entity Resolution Service response (entity representation). The source of truth for the ERS to build an entity representation can be:
The multi-strategy ERS still in experimental status, but there is a need to productionize it to support entity attributes from diverse sources. Mature organizations keep user/entity information across several kinds of systems, and as a platform we should support these.
Practically that means a subject mapping relating a condition set to an attribute value where the condition set finds
jake@acme.org IN .emailAddress, depending on the ERS running with the platform and its mode, that could be:emailAddressin my access tokenemailAddressemailAddressin my LDAP systememailAddressTLDR: we should find a clear way to communicate that entity attributes are stored in diverse systems, organized/resolved by ERS, conditionally resolved to platform Attribute Values via Subject Mappings with Subject Condition Sets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in commit 930f394 — added a :::note block immediately after the :::tip in subject_mappings.md that explains: