chore: address PR #191 review comments

[jp-ayyappan]

Summary

Addresses all review comments raised on #191. Includes a light mode pass across the entire site since the theme toggle was broken.

Changes

Reviewer-requested fixes (jp-ayyappan)

• Favicon: reverted from favicon.svg back to OpenTDF-Logo.png
• Navbar logo: reverted from opentdf-icon.svg back to OpenTDF-Logo.png; added srcDark: "img/OpenTDF-Logo-White.png" for automatic dark/light logo switching via Docusaurus's built-in srcDark config
• Light/dark mode toggle restored: navbar was hardcoded always-dark, breaking the color mode switch; made fully theme-aware

CSS improvements (gemini-code-assist)

• Navbar layout robustness: added max-width guard on the centered nav links container to prevent overlap with the absolutely-positioned brand and right items at narrow viewports
• GitHub icon deduplication: extracted the large SVG data URL into a --github-icon-svg CSS custom property; both -webkit-mask-image and mask-image now reference the variable

Code hygiene

• Removed orphaned assets: favicon.svg and opentdf-icon.svg were added by feat: redesign OpenTDF.io homepage and update documentation styling #191 and are now unreferenced — deleted
• Added static/img/OpenTDF-Logo-White.png for dark mode navbar logo
• Normalized dark mode selectors: new [data-theme='dark'] rules aligned to html[data-theme='dark'] to match the file's existing convention and specificity

Light mode for the full site

• Navbar: light glass background in light mode; dark glass in dark mode — with adaptive text, nav links, and GitHub button colors
• Footer: was always-dark; now theme-aware with light gray background, dark text, and adapted link colors in light mode
• Landing page homepage: all six sections (Hero, ProblemSolution, DeveloperFirst, Standards, Community, FinalCTA) now adapt to light mode — white/off-white section backgrounds, dark text, corrected button borders. Code windows (Hero) and TDF diagram (Standards) intentionally remain dark in both modes.
• Design tokens: added html[data-theme='light'] overrides for all --otdf-* CSS custom properties

Admonition fixes

• :::tip dark mode: was unreadable (cream background + white inherited text in dark mode); now uses a dark amber background (#451a03) with light amber text in dark mode
• :::note decoupled from amber: the original rule incorrectly targeted alert--secondary (note) alongside tip — removed; notes now use Docusaurus's default dark-mode-safe secondary styling

Preview

🔗 https://opentdf-docs-preview-191-review.surge.sh/

Test plan

• Verify homepage renders correctly in both light and dark mode
• Verify navbar logo switches between color and white versions on theme toggle
• Verify color mode toggle is visible and functional in the navbar
• Verify footer adapts to light/dark mode
• Verify :::tip admonitions are readable in both modes on a docs page (e.g. /quickstart)
• Verify :::note admonitions render with default gray styling (not amber)
• Check navbar layout at various viewport widths above the mobile breakpoint

🤖 Generated with Claude Code

[gemini-code-assist]

Summary of Changes

Hello @jp-ayyappan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request comprehensively addresses review comments from a previous iteration, primarily focusing on enhancing the site's theming capabilities. It introduces a full light mode pass across the entire website, ensuring a consistent and visually appealing experience regardless of the user's theme preference. Key updates include restoring the theme toggle, refining navigation and footer aesthetics, and improving the readability of admonition components.

Highlights

• Reviewer-requested fixes: Reverted favicon and navbar logo to OpenTDF-Logo.png and added srcDark for automatic dark/light logo switching.
• Theme Toggle Restoration: Fixed the navbar to be fully theme-aware, restoring the light/dark mode toggle functionality which was previously broken.
• CSS Improvements: Enhanced navbar layout robustness with a max-width guard on centered links and deduplicated the GitHub icon SVG data into a CSS custom property.
• Code Hygiene: Removed unreferenced favicon.svg and opentdf-icon.svg assets, added OpenTDF-Logo-White.png for dark mode, and normalized dark mode selectors to html[data-theme='dark'].
• Comprehensive Light Mode Pass: Implemented light mode styling for the navbar, footer, and all six landing page sections, including adaptive text, link colors, and button borders.
• Admonition Styling: Corrected :::tip admonition readability in dark mode with a dark amber background and light amber text, and decoupled :::note styling from amber, allowing it to use Docusaurus's default secondary styling.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• docusaurus.config.ts
  • Updated favicon to img/OpenTDF-Logo.png.
  • Changed navbar logo src to img/OpenTDF-Logo.png and added srcDark for img/OpenTDF-Logo-White.png.
• src/components/landing/Community.module.css
  • Added light mode specific overrides for card background, border, shadow, body text color, and card icon color.
• src/components/landing/DeveloperFirst.module.css
  • Implemented light mode overrides for card background, shadow, subheading color, and secondary button border color.
• src/components/landing/FinalCTA.module.css
  • Applied light mode styling to the final call-to-action section's body text color, secondary button border color, and ghost button border color and hover state.
• src/components/landing/Hero.module.css
  • Introduced light mode overrides for hero section primary body text color and secondary button border color and hover state.
• src/components/landing/ProblemSolution.module.css
  • Added light mode styles for problem/solution section cards, body text, card body text, and button border color.
• src/components/landing/Standards.module.css
  • Applied light mode styling to standards section body text, feature item text, secondary button border color, and ghost button border color and hover state.
• src/css/custom.css
  • Removed .alert--secondary from tip admonition selector to decouple note styling.
  • Added dark mode specific styles for tip admonitions.
  • Removed redundant dark mode navbar brand color override.
  • Added light mode overrides for footer background, border, title color, link item color and hover, bottom border, copyright color, and sponsor text color and link styles.
  • Introduced --github-icon-svg custom property for GitHub icon to deduplicate SVG data.
  • Updated navbar background and border for light mode.
  • Added dark mode specific navbar background and border.
  • Removed explicit navbar brand color for light mode, relying on theme inheritance.
  • Added dark mode specific navbar brand color.
  • Removed explicit navbar link color for light mode, relying on theme inheritance.
  • Added dark mode specific navbar link color.
  • Updated active/hover background color for navbar links.
  • Added max-width to centered nav links container for robustness.
  • Updated GitHub button border color for light mode.
  • Added dark mode specific GitHub button border color and text color.
  • Updated GitHub button hover styles for light mode.
  • Added dark mode specific GitHub button hover styles.
  • Added light mode overrides for --otdf-* CSS custom properties (design tokens).
• src/css/landing.css
  • Added light mode specific background styles for section-dark and section-darker.
  • Added light mode overrides for bg-grid background image and size.
  • Added light mode override for sdk-card border color.
• static/img/favicon.svg
  • Removed an unused SVG favicon asset.
• static/img/opentdf-icon.svg
  • Removed an unused SVG OpenTDF icon asset.

Activity

• Addressed all review comments raised on PR feat: redesign OpenTDF.io homepage and update documentation styling #191.
• Implemented a comprehensive light mode pass across the entire site to ensure consistent theming.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request does a great job of addressing the previous review comments and implementing a comprehensive light mode theme across the site. The changes are well-structured, particularly the refactoring of the navbar to be theme-aware and the use of CSS custom properties to deduplicate the GitHub icon SVG and manage theme tokens. The layout robustness improvements are also a welcome addition. I have one minor suggestion to further clean up a CSS rule, but overall this is excellent work.

[vmorps]

Thanks for the fixes/updates. I didn't appreciate the the light/dark mode was across both Docusaurus and the marketing webpage, too. Improvements look good, and the admonition and CSS improvements are exactly right. As proposed in Slack chat, let's handle the favicon/logo decision separately — for now, we will use a text-only logotype, no new diamond icon, no revert to old logo. That's being pushed to the branch directly. Good to merge when ready.