Open
Conversation
gztensor
added
the
skip-cargo-audit
camfairchild
suggested changes
Mar 25, 2026
Comment on lines
539
to
540
| for ((coldkey, netuid_alpha), _) in old_alpha_values { | ||
| if netuid == netuid_alpha { |
Contributor
There was a problem hiding this comment.
can this be a filter maybe?
So it's more clear that none of the loop-body should have netuid_alpha != netuid
sam0x17
previously approved these changes
Mar 26, 2026
JohnReedV
approved these changes
Mar 27, 2026
l0r1s
reviewed
Mar 27, 2026
| .saturating_add(T::DbWeight::get().writes(39_u64)), DispatchClass::Normal, Pays::No))] | ||
| #[pallet::weight((Weight::from_parts(263_300_000, 0) | ||
| .saturating_add(T::DbWeight::get().reads(45_u64)) | ||
| .saturating_add(T::DbWeight::get().writes(31_u64)), DispatchClass::Normal, Pays::No))] |
Collaborator
There was a problem hiding this comment.
Any reason to keep this Pays::No?
Suggested change
| .saturating_add(T::DbWeight::get().writes(31_u64)), DispatchClass::Normal, Pays::No))] | |
| .saturating_add(T::DbWeight::get().writes(31_u64)), DispatchClass::Normal, Pays::Yes))] |
Contributor
Author
There was a problem hiding this comment.
Good catch, I don't see any reason, and it's cleaner that way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cleanup swapping of stake when swapping hotkey
Type of Change
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctly