Skip to content

[TorchAO] [OVQuantizer] Update Torch AO Dependency and Refactor Executorch Tests#3842

Open
anzr299 wants to merge 102 commits intoopenvinotoolkit:developfrom
anzr299:an/executorch_tests
Open

[TorchAO] [OVQuantizer] Update Torch AO Dependency and Refactor Executorch Tests#3842
anzr299 wants to merge 102 commits intoopenvinotoolkit:developfrom
anzr299:an/executorch_tests

Conversation

@anzr299
Copy link
Copy Markdown
Collaborator

@anzr299 anzr299 commented Jan 15, 2026

Changes

  1. Move executorch test reference graphs from tests/torch/fx -> tests/executorch
  2. Remove OVQuantizer from NNCF and use this from executorch
  3. Remove Quantizer tests from conformance suite.

Reason for changes

(reasons are in the same order as changes above)

  1. The tests for executorch were moved from tests/torch/fx -> tests/executorch
  2. We need to keep quantizer in one place only
  3. For now, need to contain the restrict executorch requirement to only tests/executorch

CVS-176783

Tests

PTQ Conformance - PTQ-845 - Pass
Examples - https://github.com/openvinotoolkit/nncf/actions/runs/24825242781 - Pass
WC conformance - https://github.com/openvinotoolkit/nncf/actions/runs/24825249815 - Pass

pytest tests/executorch results:
image
All tests in tests/executorch pass

@anzr299 anzr299 requested a review from a team as a code owner January 15, 2026 15:33
@anzr299 anzr299 marked this pull request as draft January 15, 2026 16:44
@github-actions github-actions Bot added the API Public API-impacting changes label Jan 15, 2026
@github-actions github-actions Bot added NNCF PT Pull requests that updates NNCF PyTorch NNCF PTQ Pull requests that updates NNCF PTQ labels Jan 15, 2026
@github-actions github-actions Bot removed the NNCF PTQ Pull requests that updates NNCF PTQ label Apr 3, 2026
@github-actions github-actions Bot added the NNCF PTQ Pull requests that updates NNCF PTQ label Apr 3, 2026
Comment thread tests/executorch/test_ptq.py Outdated
from nncf.experimental.torch.fx.quantization.quantizer.openvino_quantizer import OpenVINOQuantizer
from nncf.quantization.algorithms.weight_compression.config import WeightCompressionParameters

OpenVINOQuantizer: TypeAlias = Any
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to avoid import of OpenVINO quantizer whose only purpose is type hint

@github-actions github-actions Bot added the NNCF PT Pull requests that updates NNCF PyTorch label Apr 3, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 57 out of 106 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

tests/executorch/test_quantizer_compression.py:1

  • This xfail is not marked as strict, so if the underlying issue gets fixed the test may silently become XPASS and stop providing signal. Consider setting strict=True (and ideally linking to the tracker/issue URL in the reason) so the suite forces follow-up when the failure condition changes.

Comment thread tests/executorch/conftest.py
Comment thread src/nncf/experimental/torch/fx/quantization/quantize_pt2e.py
Comment thread src/nncf/experimental/torch/fx/__init__.py
Comment thread .github/workflows/executorch.yml Outdated
@anzr299 anzr299 requested a review from daniil-lyakhov April 22, 2026 10:23
Copy link
Copy Markdown
Collaborator

@daniil-lyakhov daniil-lyakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check the dot files manually? Is everything working ok?

@daniil-lyakhov
Copy link
Copy Markdown
Collaborator

Why not to call the pre-commit executorch test like
precommit / pytest / executorch?

@anzr299
Copy link
Copy Markdown
Collaborator Author

anzr299 commented Apr 22, 2026

Did you check the dot files manually? Is everything working ok?

Yes, I checked the graphs manually

Why not to call the pre-commit executorch test like precommit / pytest / executorch?

@AlexanderDokuchaev asked me to seperate the executorch workflow from others.

Copy link
Copy Markdown
Collaborator

@daniil-lyakhov daniil-lyakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NNCF PT Pull requests that updates NNCF PyTorch NNCF PTQ Pull requests that updates NNCF PTQ

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants