[TorchAO] [OVQuantizer] Update Torch AO Dependency and Refactor Executorch Tests#3842
Open
anzr299 wants to merge 102 commits intoopenvinotoolkit:developfrom
Open
[TorchAO] [OVQuantizer] Update Torch AO Dependency and Refactor Executorch Tests#3842anzr299 wants to merge 102 commits intoopenvinotoolkit:developfrom
anzr299 wants to merge 102 commits intoopenvinotoolkit:developfrom
Conversation
| from nncf.experimental.torch.fx.quantization.quantizer.openvino_quantizer import OpenVINOQuantizer | ||
| from nncf.quantization.algorithms.weight_compression.config import WeightCompressionParameters | ||
|
|
||
| OpenVINOQuantizer: TypeAlias = Any |
Collaborator
Author
There was a problem hiding this comment.
This is to avoid import of OpenVINO quantizer whose only purpose is type hint
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 57 out of 106 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
tests/executorch/test_quantizer_compression.py:1
- This
xfailis not marked as strict, so if the underlying issue gets fixed the test may silently become XPASS and stop providing signal. Consider settingstrict=True(and ideally linking to the tracker/issue URL in the reason) so the suite forces follow-up when the failure condition changes.
AlexanderDokuchaev
requested changes
Apr 6, 2026
AlexanderDokuchaev
approved these changes
Apr 6, 2026
Collaborator
daniil-lyakhov
left a comment
There was a problem hiding this comment.
Did you check the dot files manually? Is everything working ok?
Collaborator
|
Why not to call the pre-commit executorch test like |
Collaborator
Author
Yes, I checked the graphs manually
@AlexanderDokuchaev asked me to seperate the executorch workflow from others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Reason for changes
(reasons are in the same order as changes above)
CVS-176783
Tests
PTQ Conformance - PTQ-845 - Pass
Examples - https://github.com/openvinotoolkit/nncf/actions/runs/24825242781 - Pass
WC conformance - https://github.com/openvinotoolkit/nncf/actions/runs/24825249815 - Pass
pytest tests/executorch results:

All tests in tests/executorch pass