perf(webf): land layout optimization stack and follow-up fixes#898
Merged
perf(webf): land layout optimization stack and follow-up fixes#898
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fe8ab2a to
9acd5f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch lands the current layout optimization stack on top of
main, plus the follow-up correctness fixes that came out of the rendering regression work.Highlights:
WidgetElementroots use popup/portal constraints without regressingCupertinoContextMenupreview sizingIncluded Commits
ae3b84cf0feat: add agent skills896c27c7fprofiler: add profiler test specs.ec95a67c4perf(webf): reduce relayouts in flex fast path013f63310fix(webf): restore stable flex layout behavior5542753e2perf(webf): reduce redundant flex fast-path relayouts08af71710perf(webf): narrow mixed flex measurement reusecbcd4013aperf(webf): skip futile early flex run-metrics passes951e67344perf(webf): reduce layout constraint overheadb5efce08dperf(webf): optimize layout hotspotsad9948096perf(webf): narrow flex cache reuse under wrapped layoutscd30747e8perf(webf): optimize flex hotspot profilingc6b0d4051fix(webf): avoid debug-only layout reuse checks94aa230cafix(webf): correct widget layout reuse in flex5f8c32c95fix(webf): narrow portal width fallbackfe8ab2a38fix(webf): avoid phantom flex scroll rangeValidation
flutter test /Users/andycall/workspace/webf3/webf/test/src/rendering/render_widget_portal_constraints_test.dartflutter test /Users/andycall/workspace/webf3/webf/test/src/rendering/render_widget_percentage_width_test.dartflutter test /Users/andycall/workspace/webf3/webf/test/src/rendering/flex_item_width_test.dartnpm run integration -- specs/rendering/widget_cupertino_context_menu_popup_preview_width.ts specs/rendering/widget_portal_cupertino_modal_popup_width_not_clamped.tsflutter analyze --no-pub /Users/andycall/workspace/webf3/webf/lib/src/css/render_style.dartflutter analyze --no-pub /Users/andycall/workspace/webf3/webf/lib/src/rendering/flex.dartNotes
This is a stacked branch rather than a single-fix PR. The two latest fixes are:
WidgetElementroots only