Conversation
* Make links with `pg_files` start with a leading slash. * Honor the showCorrectAnswers setting and don't force it to be 2. * Make pg_files thirdPartyAssessts not force CDN use. * Remove the no longer needed `s/#/@/g` from version strings. * Some minor code cleanups.
drgrice1
left a comment
drgrice1
left a comment
There was a problem hiding this comment.
This is not the correct baseURL approach. The key for the correct way to do this is to use the url_for method and route names (with appropriate stash values in some cases). I will put in a pull request at some point that fixes this. I have it implemented, but I am waiting for some of my other pull requests to be merged before I put it out there.
| showCorrectAnswers => $inputs_ref->{showCorrectAnswers} ? 2 : 0, | ||
| num_of_correct_ans => $inputs_ref->{numCorrect} || 0, | ||
| num_of_incorrect_ans => $inputs_ref->{numIncorrect} || 0, | ||
| showCorrectAnswers => $inputs_ref->{showCorrectAnswers} && $displayResults || 0, |
There was a problem hiding this comment.
This is still not right. The value of showCorrectAnswers should be numeric and should be one of 0, 1, or 2. This does not allow for a value of 2 which is the case that correct answers are shown without the button to reveal the correct answers.
|
I will split this up, and remove the baseURL update, though I would like your baseURL fix when you are ready to make a PR with it. |
|
Closing, in favor of a better baseURL approach. |
2 participants
pg_filesstart with a leading slash.s/#/@/gfrom version strings.