adblock-fast: fix unbound out filter name#28473
Closed
tobiaswaldvogel wants to merge 1 commit intoopenwrt:masterfrom
Closed
adblock-fast: fix unbound out filter name#28473tobiaswaldvogel wants to merge 1 commit intoopenwrt:masterfrom
tobiaswaldvogel wants to merge 1 commit intoopenwrt:masterfrom
Conversation
Signed-off-by: Tobias Waldvogel <tobias.waldvogel@gmail.com> The last commit before changed the name of the output filter $unboundFilter to $unboundOutputFormatFilter. As this was not adjusted everywhere this broke the unbound integration.
tobiaswaldvogel
force-pushed
the
adblock-fast-fix-unbound
branch
from
73c89ce to
e6e8382
Compare
Member
|
You should bump the And the sign-off should be at the end of the commit message. |
stangri
approved these changes
Feb 1, 2026
Member
|
Closing as the main codebase moved to ucode and this is no longer relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @stangri
Description:
After renaming the the output filter, the unbound filter name was not updated everywhere, which broke the unbound integration
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.