zabbix: fix no-configure build variant#28495
Merged
mhei merged 1 commit intoopenwrt:masterfrom Feb 6, 2026
Merged
Conversation
When selecting only a package of "no-configure" build variant, e.g. CONFIG_PACKAGE_zabbix-frontend-server=y but not any other zabbix package, then the build fails. The sources are not extracted and the install fails finally with: make[4]: Entering directory '/srv/openwrt/openwrt-2.git/build_dir/target-arm_arm926ej-s_musl_eabi/zabbix-no-configure/zabbix-7.0.22' make[4]: *** No rule to make target 'install'. Stop. make[4]: Leaving directory '/srv/openwrt.git/build_dir/target-arm_arm926ej-s_musl_eabi/zabbix-no-configure/zabbix-7.0.22' make[3]: *** [Makefile:522: /srv/openwrt.git/build_dir/target-arm_arm926ej-s_musl_eabi/zabbix-no-configure/zabbix-7.0.22/.built] Error 2 This PR fixes this by always running the standard Prepare stage, but skip the Install one when nothing needs to be compiled. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
Contributor
|
@mhei Thank you for this. I misunderstood the stages (and missed checking that build configuration). |
Contributor
|
I'll make sure I didn't get that mistake into the 25.12 branch. If not, I think I'm going to not cherry-pick anything more for 25.12 (I think I got the most important ones for 25.12; the update to 7.0.22, the server initscript, and fixes for mistakes in getting there). |
Contributor
|
No such luck. It is present in a previous cherry-pick. I'll work on taking the time to make sure the series on master to this point can be safely cherry-picked (and fix if/where necessary). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @danielfdickinson
Description:
When selecting only a single package of "no-configure" build variant, e.g. CONFIG_PACKAGE_zabbix-frontend-server=y
but not any other zabbix package, then the build fails. The sources are not extracted and the install fails finally with:
This PR fixes this by always running the standard Prepare stage, but skip the Install one when nothing needs to be compiled.
🧪 Run Testing Details
not run tested, addresses only a build issue
✅ Formalities