Openx bid adapter: support for MAP requests#102
Open
Rafał Sieczka (bukrain) wants to merge 7 commits intomasterfrom
Open
Openx bid adapter: support for MAP requests#102Rafał Sieczka (bukrain) wants to merge 7 commits intomasterfrom
Rafał Sieczka (bukrain) wants to merge 7 commits intomasterfrom
Conversation
| bidRequestsWithMediaTypes[0].params.delDomain = 'domain-a.test'; | ||
| bidRequestsWithMediaTypes[1].params.delDomain = 'domain-b.test'; | ||
| const request = spec.buildRequests(bidRequestsWithMediaTypes, mockBidderRequest); | ||
| expect(request[0].data.ext.delDomain).to.equal('domain-a.test'); |
There was a problem hiding this comment.
[question] Now bids with different delDomains into one request and only first bid's delDomain is sent and others are dropped?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (isFingerprintingApiDisabled('webdriver')) { | ||
| return false; | ||
| } | ||
| return getFallbackWindow(win).navigator?.webdriver === true; |
Check warning
Code scanning / CodeQL
Use of browser API associated with fingerprinting Warning
| deepSetNotEmptyValue(qs, '51D_ScreenPixelsHeight', _window?.screen?.height); | ||
| deepSetNotEmptyValue(qs, '51D_ScreenPixelsWidth', _window?.screen?.width); | ||
| deepSetNotEmptyValue(qs, '51D_PixelRatio', _window?.devicePixelRatio); | ||
| deepSetNotEmptyValue(qs, '51D_PixelRatio', getDevicePixelRatio(_window)); |
Check warning
Code scanning / CodeQL
Use of browser API associated with fingerprinting Warning
Pull Request Test Coverage Report for Build 22619502230Details
💛 - Coveralls |
Rafał Sieczka (bukrain)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information