🌱 Return *DeploymentConfig directly from GetDeploymentConfig()

[joelanford]

Description

GetDeploymentConfig() previously returned map[string]any, requiring callers to
immediately convert it to a *DeploymentConfig via a separate convertToDeploymentConfig()
function. This changes the method to return (*DeploymentConfig, error) directly,
eliminating the unnecessary indirection.

Changes:

• config/config.go: GetDeploymentConfig() now returns (*DeploymentConfig, error) instead of map[string]any, unmarshaling directly into the struct internally
• applier/provider.go: Removed convertToDeploymentConfig() function; caller now uses the *DeploymentConfig directly
• config/config_test.go: Updated test expectations for new return type; removed defensive-copy test (no longer applicable to struct return)

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

Generated with Claude Code

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	bb588d5
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/69c43e4b4b25ac0008ee0a45
😎 Deploy Preview	https://deploy-preview-2598--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[tmshort]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Copilot]

Pull request overview

This PR simplifies how deployment configuration is accessed by changing Config.GetDeploymentConfig() to return a typed *DeploymentConfig (with an error) directly, removing the need for callers to convert from a generic map[string]any.

Changes:

• Updated GetDeploymentConfig() to unmarshal into DeploymentConfig internally and return (*DeploymentConfig, error).
• Removed convertToDeploymentConfig() and updated the applier to consume the typed config directly.
• Updated unit tests to assert against *config.DeploymentConfig and the new error return.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
internal/operator-controller/config/config.go	Changes GetDeploymentConfig() to return (*DeploymentConfig, error) and unmarshal internally.
internal/operator-controller/applier/provider.go	Removes map→struct conversion helper; uses the new accessor directly.
internal/operator-controller/config/config_test.go	Updates expectations for the new return type and error handling.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[joelanford]

/hold

Still self-reviewing Claude's work and making sure I address Copilot's feedback.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[joelanford]

/hold cancel

[codecov]

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.96%. Comparing base (71a91dc) to head (bb588d5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/operator-controller/applier/provider.go	50.00%	1 Missing and 1 partial ⚠️
internal/operator-controller/config/config.go	90.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2598      +/-   ##
==========================================
+ Coverage   67.81%   67.96%   +0.15%     
==========================================
  Files         137      137              
  Lines        9588     9575      -13     
==========================================
+ Hits         6502     6508       +6     
+ Misses       2586     2573      -13     
+ Partials      500      494       -6     

Flag	Coverage Δ
e2e	38.32% <0.00%> (+0.31%)	⬆️
experimental-e2e	50.99% <50.00%> (+0.04%)	⬆️
unit	52.96% <78.57%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.