You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Improved schema name handling: returns None for absent inputs, normalizes names for specialized node types, and trims trailing "Sync" suffix where applicable.
Tests
Added unit tests covering the updated schema name resolution behavior.
✏️ Tip: You can customize this high-level summary in your review settings.
The get_schema_name function in infrahub_sdk/store.py was reworked to explicitly handle CoreNodeBase subclasses: it returns None for None input, detects whether the class save method is a coroutine, and strips a trailing Sync suffix from class names. A prior runtime-protocol attribute check was removed. New imports for inspect and CoreNodeBase were added. Unit tests were added to verify the function returns the expected names for BuiltinIPPrefix and BuiltinIPAddressSync.
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.
Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name
Status
Explanation
Description Check
✅ Passed
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
✅ Passed
The title directly describes the main change: refactoring get_schema_name to use CoreNodeBase for type checking instead of previous runtime-protocol attribute check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.