Skip to content

fix(embed): handle absolute file paths from native engine #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlos-alm merged 8 commits into from
Apr 3, 2026
Merged

fix(embed): handle absolute file paths from native engine #780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3ef55df
fix(embed): handle absolute file paths from native engine (#752)
carlos-alm Apr 3, 2026
26bc6e7
style: fix biome format in test
carlos-alm Apr 3, 2026
f9ee3ed
fix: resolve merge conflicts with main
carlos-alm Apr 3, 2026
e44ad60
fix: apply isAbsolute guard to native fast-path and add source strate…
carlos-alm Apr 3, 2026
90282a0
Merge branch 'main' into fix/752-embed-absolute-paths
carlos-alm Apr 3, 2026
e07a5e7
Merge remote-tracking branch 'origin/main' into fix/752-embed-absolut…
carlos-alm Apr 3, 2026
1847de5
Merge branch 'fix/752-embed-absolute-paths' of https://github.com/opt…
carlos-alm Apr 3, 2026
656dbb4
Merge branch 'main' into fix/752-embed-absolute-paths
carlos-alm Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/domain/graph/builder/stages/detect-changes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ function findReverseDependencies(
const changedArray = [...changedRelPaths];
const nativeResults = nativeDb.findReverseDependencies(changedArray);
for (const dep of nativeResults) {
const absPath = path.join(rootDir, dep);
const absPath = path.isAbsolute(dep) ? dep : path.join(rootDir, dep);
if (fs.existsSync(absPath)) {
reverseDeps.add(dep);
}
Expand All @@ -366,7 +366,7 @@ function findReverseDependencies(
for (const relPath of changedRelPaths) {
for (const row of findReverseDepsStmt.all(relPath) as Array<{ file: string }>) {
if (!changedRelPaths.has(row.file) && !reverseDeps.has(row.file)) {
const absPath = path.join(rootDir, row.file);
const absPath = path.isAbsolute(row.file) ? row.file : path.join(rootDir, row.file);
if (fs.existsSync(absPath)) {
reverseDeps.add(row.file);
}
Expand Down
12 changes: 10 additions & 2 deletions tests/search/embedding-strategy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ describe('FTS5 index built alongside embeddings', () => {
});
});

describe('absolute file paths in DB (#760)', () => {
describe('absolute file paths in DB (#752)', () => {
let absDir: string, absDbPath: string;

beforeAll(() => {
Expand All @@ -314,7 +314,7 @@ describe('absolute file paths in DB (#760)', () => {
if (absDir) fs.rmSync(absDir, { recursive: true, force: true });
});

test('produces embeddings when DB stores absolute paths', async () => {
test('produces embeddings when DB stores absolute paths (structured)', async () => {
EMBEDDED_TEXTS.length = 0;
await buildEmbeddings(absDir, 'minilm', absDbPath);

Expand All @@ -325,6 +325,14 @@ describe('absolute file paths in DB (#760)', () => {
db.close();
expect(count).toBe(1);
});

test('produces embeddings when DB stores absolute paths (source)', async () => {
EMBEDDED_TEXTS.length = 0;
await buildEmbeddings(absDir, 'minilm', absDbPath, { strategy: 'source' });

expect(EMBEDDED_TEXTS.length).toBe(1);
expect(EMBEDDED_TEXTS[0]).toContain('add');
});
});

describe('context window overflow detection', () => {
Expand Down
Loading