-
Notifications
You must be signed in to change notification settings - Fork 4
fix(perf): wire engine selection through openRepo to fix query benchmarks #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KNOWN_REGRESSIONSentries have no expiry enforcementThe three
3.9.0:fnDeps depth {1,3,5}entries are documented in the inline comment above (lines 68–73) to be removed once v3.10.0 benchmark data is merged. There is no automated check that enforces this cleanup. If these entries are left in place after v3.10.0 data lands, the regression guard will silently pass genuine regressions in those three metrics for all future releases.Consider adding a test-time assertion that checks the current package version and warns (or fails) when any
KNOWN_REGRESSIONSentry is more than one minor version behind the running package — this would make the stale-exemption problem self-detecting rather than requiring manual bookkeeping.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in b6e919a. Added a
KNOWN_REGRESSIONS entries are not staletest that reads the current package version, computes the minor-version gap for each entry, and fails when any entry is more than 1 minor version behind. This makes stale exemptions self-detecting — the test will fail as soon as v3.10.0 is released if the entries aren't cleaned up.