Skip to content

fix: revert version bump to 3.9.1 for clean publish#894

Merged
carlos-alm merged 1 commit intomainfrom
fix/revert-version-bump-392
Apr 7, 2026
Merged

fix: revert version bump to 3.9.1 for clean publish#894
carlos-alm merged 1 commit intomainfrom
fix/revert-version-bump-392

Conversation

@carlos-alm
Copy link
Copy Markdown
Contributor

Summary

After merging: delete the existing v3.9.2 GitHub release and tag, then re-create the release with tag v3.9.2 targeting main. The publish workflow will bump versions atomically after building native binaries.

Test plan

  • Preflight tests pass (no version mismatch between package.json and native binary)
  • Re-triggered v3.9.2 publish workflow completes successfully

The v3.9.2 release PR (#891) bumped package.json and Cargo.toml to
3.9.2 while optionalDependencies still pointed to 3.9.1. This caused
preflight tests to fail because the installed native binary (3.9.1)
mismatched the declared version (3.9.2). Reverting to 3.9.1 so the
publish workflow can bump versions atomically after building native
binaries at the correct version.
@claude
Copy link
Copy Markdown

claude bot commented Apr 7, 2026

Claude finished @carlos-alm's task —— View job


PR Review Analysis

Reviewing this PR following the codegraph review framework:

Root Cause Analysis

Problem Being Solved: The v3.9.2 release (#891) created a version mismatch where:

Why This Approach: Reverting to 3.9.1 allows for a clean re-release where the publish workflow can atomically bump both the core version AND build matching native binaries, ensuring consistency.

Risk Assessment: ✅ This addresses the actual root cause, not symptoms. The plan to delete the existing v3.9.2 tag/release and recreate it is the correct approach for atomic version management.

Backlog Compliance

  • Zero-dep: ✓ — No new runtime dependencies added
  • Foundation-aligned: ✓ — Maintains build pipeline integrity, supports P1 (always-current)
  • Problem-fit: 3 — Fixes infrastructure issue that would block AI agents, but doesn't directly reduce token waste
  • Breaking: No — Pure version reversion with no behavioral changes
  • Tier: 1

Configuration & Test Analysis

✅ CLEAN - No risky changes detected:

  • No biome/linting rules modified
  • No test timeouts, coverage thresholds, or assertions weakened
  • No build configuration changes
  • Pure version reversion in 3 files only
  • Version validation system at src/db/connection.ts:316-321 confirms this fixes legitimate mismatch

Code Quality

The changes are trivial version string updates:

  • package.json: 3.9.2 → 3.9.1 (line 3)
  • crates/codegraph-core/Cargo.toml: 3.9.2 → 3.9.1 (line 3)
  • package-lock.json: 3.9.2 → 3.9.1 (lines 3, 8)

No functional logic changed. The optionalDependencies correctly point to existing 3.9.1 native binaries, resolving the version consistency issue.

Critical Concerns

None. This is a necessary infrastructure fix that enables the correct release process.

Final Recommendation

  • Rating: ⭐⭐⭐⭐☆ (4/5)
  • Action: APPROVE
  • Reasoning: Clean, focused fix that addresses the root cause of build pipeline failures. The approach (revert → clean re-release) follows proper version management practices. No code quality concerns given the trivial nature of version string changes.

Post-merge steps: As noted in PR description, delete the existing v3.9.2 GitHub release/tag, then re-trigger the release workflow targeting main to create a clean atomic v3.9.2 release.


@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 7, 2026

Greptile Summary

This PR reverts package.json, package-lock.json, and crates/codegraph-core/Cargo.toml from 3.9.2 back to 3.9.1, resolving a version mismatch where the native binary packages still referenced 3.9.1 while the declared package version had been bumped to 3.9.2. All three files are internally consistent at 3.9.1, and the sync-native-versions.ts npm lifecycle hook will ensure atomic version sync on the next publish run.

Confidence Score: 5/5

Safe to merge — clean version revert with all three files consistently aligned to 3.9.1

No code logic changes; all version files are internally consistent; sync-native-versions.ts prevents future mismatches via the npm version lifecycle hook; post-merge steps are documented in the PR description.

No files require special attention — changes are purely version number reverts

Important Files Changed

Filename Overview
package.json Version reverted to 3.9.1; optionalDependencies for @optave/codegraph-* consistently point to 3.9.1
package-lock.json Lock file version reverted to 3.9.1 to match package.json
crates/codegraph-core/Cargo.toml Cargo.toml version reverted to 3.9.1 to match npm package version

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Merge PR #894
Revert to v3.9.1] --> B[Delete v3.9.2 tag
& GitHub release]
    B --> C[Re-trigger publish.yml
workflow_dispatch]
    C --> D[Build native binaries
for all 6 platforms]
    D --> E[npm version lifecycle
runs sync-native-versions.ts]
    E --> F[optionalDependencies synced
to new version atomically]
    F --> G[Publish @optave/codegraph
and platform packages]
Loading

Reviews (1): Last reviewed commit: "fix: revert version bump to 3.9.1 for cl..." | Re-trigger Greptile

@carlos-alm carlos-alm merged commit 72237e6 into main Apr 7, 2026
23 checks passed
@carlos-alm carlos-alm deleted the fix/revert-version-bump-392 branch April 7, 2026 08:23
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant