Open
Conversation
…e_once, require, and include_once statements. Added PHPUnit 9 and cleaned up test cases so they comply with PSR-4 also.
yakushevi
reviewed
May 10, 2021
| } | ||
| if ($apiVersion == null) { | ||
| $this->apiVersion = '5.0'; | ||
| $this->apiVersion = '5.3'; |
There was a problem hiding this comment.
@mstralka Tested this and unfortunately nameapi do not have a /5.3/ endpoint and the requests return 404.
You should revert it back to "5.0".
You can find a similar commit from 2017: f2ff68f
Edit: Solved it by changing the host from rc50-api.nameapi.org to rc53-api.nameapi.org so you should probably disregard this comment.
…ied the PersonNameParserService to use these functions because the API throws a 500 exception if the payload has attributes with NULL values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I refactored the package names and fixed the unit tests so it will comply with PSR-4 naming. This fixes #13