implemented UNION (and a few other query operators)#184
Open
implemented UNION (and a few other query operators)#184
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
connelly38
reviewed
Jan 19, 2026
Member
There was a problem hiding this comment.
Was this checked in by mistake?
jinzha
reviewed
Mar 13, 2026
| FN_MIN_MAX(41), | ||
|
|
||
| SEQ_AGGR(48), | ||
| SORT(47), |
Member
There was a problem hiding this comment.
Swap SEQ_AGGR and SORT to maintain ascending order?
jinzha
reviewed
Mar 13, 2026
|
|
||
| if (!theRCB.reachedLimit()) { | ||
| reqCopy.setMaxReadKB(origRequest.getMaxReadKB() - | ||
| theRCB.getReadKB()); |
Member
There was a problem hiding this comment.
The maxReadKB of QueryRequest must be >=0. If origRequest.maxReadKB is not specified, it defaults to 0, then origRequest.getMaxReadKB() - theRCB.getReadKB() is negative and results in an IllegalArgumentException.
public QueryRequest setMaxReadKB(int maxReadKB) {
if (maxReadKB < 0) {
throw new IllegalArgumentException("maxReadKB must be >= 0");
}
this.maxReadKB = maxReadKB;
return this;
}
jinzha
reviewed
Mar 16, 2026
| * @param sqlText the query | ||
| * @param queryPlan the query plan | ||
| * @param querySchema the query schema | ||
| * @param proxyStatement proxy statement |
Member
There was a problem hiding this comment.
The Javadoc for the parameters proxyStatement, namespace, and tableName should be updated accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.