Conversation
Replaces the <link rel="preload"> hint with a <style> block containing the inlined CSS content, eliminating the extra network round-trip. Also removes the Docusaurus-generated <link rel="stylesheet"> for the same file to prevent double-loading. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
aeneasr
requested review from
piotrmsc,
unatasha8,
vinckr and
zepatrik
as code owners
String matching on the <link> tag was fragile due to attribute order. Switch to cheerio so we select by attribute values regardless of order, and replaceWith() drops the external link and inlines the <style> block in one step. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Avoids a DOM parsing dependency for a simple string replacement. The regex matches the href regardless of attribute order. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<link rel="preload" as="style">with an inline<style>block containing the full CSS content<link rel="stylesheet">Docusaurus injects for the same file to prevent double-loadingpreload-css→embed-cssTest plan
npm run buildand inspect a generated HTML file inbuild/— confirm a<style>block is present in<head>with Tailwind/theme CSS<link rel="stylesheet" href="...styles.*.css">remains in the output HTMLnpm run serveand verify styles render correctly with no flash of unstyled content🤖 Generated with Claude Code