feat(sdk): add agent state, conditions, drain/undrain#33
Merged
Conversation
Add State, Conditions, and Timeline fields to the Agent domain type. Add Drain() and Undrain() methods to AgentService for managing agent job acceptance. Add ConflictError (409) to the typed error hierarchy. Move TimelineEvent to shared types.go since it is used by both agent and job types. Regenerate client from updated API spec. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Thank you for contributing to this project! 😊🕹️ |
Merge split test methods (TestFoo, TestFooError, TestFooNilResponse) into single table-driven methods per function under test. Reduces ~150 suite methods to ~45 while preserving all 290 test cases. Add explicit one-suite-method-per-function rule to CLAUDE.md and docs/development.md to prevent future fragmentation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #33 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 1425 1484 +59
=========================================
+ Hits 1425 1484 +59
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
State,Conditions, andTimelinefields to theAgentdomain typeDrain()andUndrain()methods toAgentServicefor managing agent job acceptanceConflictError(409) to the typed error hierarchyTimelineEventto sharedtypes.go(used by both agent and job types)Test plan
agentFromGencovering state, conditions, and timeline (including error events)Drain()andUndrain()service methodsConflictError(409)checkError409 handling🤖 Generated with Claude Code