Skip to content

refactor(sdk): split TestDerefHelpers into table-driven methods#36

Merged
retr0h merged 1 commit intomainfrom
refactor/table-driven-deref-tests
Mar 6, 2026
Merged

refactor(sdk): split TestDerefHelpers into table-driven methods#36
retr0h merged 1 commit intomainfrom
refactor/table-driven-deref-tests

Conversation

@retr0h
Copy link
Collaborator

@retr0h retr0h commented Mar 6, 2026

Summary

  • Split monolithic TestDerefHelpers() into 6 individual suite methods, one per function under test
  • Each method uses table-driven pattern with validateFunc callbacks per project conventions
  • Functions now tested individually: derefString, derefInt, derefInt64, derefFloat64, derefBool, jobIDFromGen

Test plan

  • All TestNodeTypesTestSuite tests pass
  • No behavioral changes, only structural refactor

🤖 Generated with Claude Code

Split monolithic TestDerefHelpers into one suite method per
function under test, each using table-driven pattern with
validateFunc callbacks per project conventions.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Thank you for contributing to this project! 😊🕹️

@retr0h retr0h merged commit ee964e1 into main Mar 6, 2026
5 checks passed
@retr0h retr0h deleted the refactor/table-driven-deref-tests branch March 6, 2026 21:33
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         1653      1653           
=========================================
  Hits          1653      1653           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66626cd...38d2399. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant