Skip to content

fix(sdk): avoid package shadow in example#253

Merged
retr0h merged 1 commit intomainfrom
fix/example-client-shadow
Mar 12, 2026
Merged

fix(sdk): avoid package shadow in example#253
retr0h merged 1 commit intomainfrom
fix/example-client-shadow

Conversation

@retr0h
Copy link
Collaborator

@retr0h retr0h commented Mar 12, 2026

The local variable client shadowed the package
import, causing *client.Client in TaskFunc
closures to fail with "client.Client is not a type".

JIRA: None

The local variable `client` shadowed the package
import, causing `*client.Client` in TaskFunc
closures to fail with "client.Client is not a type".

Co-Authored-By: Claude <noreply@anthropic.com>
JIRA: None
@github-actions
Copy link
Contributor

Thank you for contributing to this project! 😊🕹️

@retr0h retr0h merged commit 1a67f5c into main Mar 12, 2026
7 checks passed
@retr0h retr0h deleted the fix/example-client-shadow branch March 12, 2026 15:06
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files         224      224           
  Lines        9431     9431           
=======================================
  Hits         9426     9426           
  Misses          3        3           
  Partials        2        2           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 891916f...0e3696f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

retr0h added a commit that referenced this pull request Mar 12, 2026
The local variable `client` shadowed the package
import, causing `*client.Client` in TaskFunc
closures to fail with "client.Client is not a type".

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant