Rename server_url to server_hostname in registrations

[lzap]

I just noticed that we have a very misleading field name in registrations: server_url. This must not be URL, in fact, it breaks RHSM client it only accepts a hostname or IP:

[server]
hostname = subscription.rhsm.redhat.com

...

[rhsm]
baseurl = https://cdn.redhat.com

Base URL is correct.

I would like to fix this there is still time, tho, @achilleas-k already started using this in his monster CLI integration PR in composer. This draft does not anything yet, I want to discuss this how to approach this.

There are several options:

• Do nothing. :-)
• Keep it as URL and parse the value extracting only the hostname.
• Rename and break the contract.
• Rename but make a fallback unmarshaller that will accept the old field name as well.
• Other ideas.

[mvo5]

AIUI we would have to change "images" here, no? This is just a direct mapping of https://github.com/osbuild/images/blob/423d32a0853f1f7ea6ab03507090a11903792dfe/pkg/customizations/subscription/subscription.go#L11 which is also used in composer. Don't get me wrong, I'm in favor for making this cleaner maybe we could just with alias fields or something so there is less risk of breaking anything?

[lzap]

Yes, that is why I am asking for opinions on how to approach this.

From what I remember, @achilleas-k was always for just "break it, fix it quickly".

[achilleas-k]

This is just a README change?

The format of the config needs to be changed in images.

FWIW, the actual underlying command has already been updated internally: osbuild/images#2071

The question is where and how this was exposed and what should we change (and how)?

I think (off the top of my head now) that we never exposed these options in composer-cli for osbuild-composer. They were only ever set by the service, so as far as that's concerned, there is little issue. If we change the option name in images and then osbuild-composer, we would have to coordinate the change with the frontend when the backend gets updated, but that's simple enough.

There are several options:

* Do nothing. :-)

* Keep it as URL and parse the value extracting only the hostname.

* Rename and break the contract.

* Rename but make a fallback unmarshaller that will accept the old field name as well.

* Other ideas.

The external option mirroring the internal one is convenient. We don't know if this option has ever been used, but we should at least try to maintain some backwards compatibility. I'd at least deprecate the old option name with a warning for a version or two before removing it. As far as I know, even back when it was called --serverurl for subscription-manager, it expected just a hostname.

[achilleas-k]

Also, keep in mind, this was only ever set in the service to register with the staging subscription management service when building images in stage.c.rh.c. It might make more sense to drop it altogether.

[lzap]

Actually, @jlsherrill just opened a PR that converts the field from hostname:port to proper URI and I suggested that since this is a breaking change why not support both: osbuild/images#2115

This is just a README change?

This was meant to start the discussion and either do a code change, or whatever is needed.

[github-actions]

This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days.

[lzap]

This is no longer needed, URL is supported as well.