Implemented auto-kicking members if no introduction provided in 24 hours of joining the group#28
Open
daemon1024 wants to merge 3 commits intoosdc:masterfrom
Open
Implemented auto-kicking members if no introduction provided in 24 hours of joining the group#28daemon1024 wants to merge 3 commits intoosdc:masterfrom
daemon1024 wants to merge 3 commits intoosdc:masterfrom
Conversation
Member
|
@daemon1024 Please close and reopen the PR to run the GH Workflow tests. |
Member
Author
|
@sidntrivedi012 I guess that should do :) |
sidntrivedi
requested changes
Sep 23, 2020
| bot.Send(reply) | ||
| } | ||
|
|
||
| func introverify(user *tbot.User, ID int64, client mongo.Client) { |
Member
There was a problem hiding this comment.
introverify?? 😅 Please write a better name for the function.
| deletenote(ID, update.Message.Text, *client) | ||
| case "fetchnote": | ||
| fetchnote(ID, update.Message.Text, *client) | ||
| case "introduction": |
Member
There was a problem hiding this comment.
Suggested change
| case "introduction": | |
| case "intro": |
| if result.MatchedCount > 0 { | ||
| bot.Send(tbot.NewMessage(ID, "Thanks for introducing yourself, You are now a verified member of OSDC :) ")) | ||
| } else { | ||
| bot.Send(tbot.NewMessage(ID, "No need to introduce again, I already know you.")) |
Member
There was a problem hiding this comment.
Suggested change
| bot.Send(tbot.NewMessage(ID, "No need to introduce again, I already know you.")) | |
| bot.Send(tbot.NewMessage(ID, "Thanks but no need to introduce again, I already know you.")) |
|
|
||
| } | ||
|
|
||
| func introkick(ID int64, client mongo.Client) { |
Member
There was a problem hiding this comment.
Suggested change
| func introkick(ID int64, client mongo.Client) { | |
| func noIntroKick(ID int64, client mongo.Client) { |
| if err != nil { | ||
| log.Fatal(err) | ||
| } else { | ||
| // log.Println(time.Now().Local().Day(), result.JoinDate.Day()) |
Member
There was a problem hiding this comment.
Please remove the stale comments
| curDay := time.Now().Local().Day() | ||
| User := fmt.Sprintf("[%v](tg://user?id=%v)", result.FirstName, result.UserID) | ||
| log.Println(curDay-result.JoinDate.Day(), curHour-result.JoinDate.Hour()) | ||
| if (curDay-result.JoinDate.Day() > 0 && curHour-result.JoinDate.Hour() > 0) || curDay-result.JoinDate.Day() > 1 { |
Member
There was a problem hiding this comment.
Does the Day return the date? In that case, if curDay is 1 and JoinDate.Day() is 31. The result may be negative.
Try taking the mod of difference if that's the case.
| if (curDay-result.JoinDate.Day() > 0 && curHour-result.JoinDate.Hour() > 0) || curDay-result.JoinDate.Day() > 1 { | ||
| go kickUser(result.UserID, ID) | ||
| collection.DeleteOne(context.TODO(), bson.M{"userid": result.UserID}) | ||
| reply := tbot.NewMessage(ID, User+" kicked. `Reason : No introduction within 24 hours of joining`") |
Member
There was a problem hiding this comment.
Also, please make the deadline as 48 hours
| reply.ParseMode = "markdown" | ||
| bot.Send(reply) | ||
| } else { | ||
| reply := tbot.NewMessage(ID, User+", Please introduce yourself in the next 12 hours or I will not be able to verify your presence and will have to kick you.") |
Member
There was a problem hiding this comment.
Suggested change
| reply := tbot.NewMessage(ID, User+", Please introduce yourself in the next 12 hours or I will not be able to verify your presence and will have to kick you.") | |
| reply := tbot.NewMessage(ID, User+", Hey, This is your friendly osdc-bot. Please introduce yourself on the OSDC group in the next 12 hours or I will not be able to verify your presence and will have to kick you. Just a simple introduction about your interests, experience will be enough.") |
Member
|
@daemon1024 Since its a quite dangerous feature, thus it will be great if you or anyone can write tests for it too. Not necessarily in this PR. But, writing tests will help to validate this feature in a better way. |
daemon1024
force-pushed
the
master
branch
3 times, most recently
from
5558973 to
6adc0b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12