Skip to content

update backward-cpp lib#88

Open
mosfet80 wants to merge 4 commits intoosrf:rollingfrom
mosfet80:updatebackward-cpp
Open

update backward-cpp lib#88
mosfet80 wants to merge 4 commits intoosrf:rollingfrom
mosfet80:updatebackward-cpp

Conversation

@mosfet80
Copy link
Copy Markdown
Contributor

@mosfet80 mosfet80 commented Jun 28, 2024 •
edited
Loading

updated backward-cpp to last version
this also solves compiling under openSUSE Tumbleweed

@mosfet80 mosfet80 requested a review from gbiggs as a code owner June 28, 2024 15:51
@mosfet80 mosfet80 mentioned this pull request Jun 28, 2024
Closed
@mosfet80
update backward-cpp
5aee0cc 
updated backward-cpp to last version
fix compile under openSUSE Tumbleweed
@mosfet80 mosfet80 force-pushed the updatebackward-cpp branch from 20c8351 to 5aee0cc Compare August 26, 2025 10:50
@mosfet80 mosfet80 changed the title update backward-cpp update backward-cpp lib Jan 5, 2026
@mosfet80
Copy link
Copy Markdown
Contributor Author

mosfet80 commented Jan 11, 2026

@gbiggs ping

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Jan 14, 2026

Pulls: #88
Gist: https://gist.githubusercontent.com/wjwwood/3696e064921ffbdca1a5aa62e5beec0d/raw/9219c2bb6c10e3b1fc230371fa447d26cb3db37c/ros2.repos
BUILD args: --packages-above-and-dependencies osrf_testing_tools_cpp
TEST args: --packages-above osrf_testing_tools_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17958

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

wjwwood
wjwwood approved these changes Jan 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Jan 16, 2026

Pulls: #88
Gist: https://gist.githubusercontent.com/wjwwood/ebae6f84c17a06e462dd6b45ae834564/raw/9219c2bb6c10e3b1fc230371fa447d26cb3db37c/ros2.repos
BUILD args: --packages-above-and-dependencies osrf_testing_tools_cpp
TEST args: --packages-above osrf_testing_tools_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17974

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@wjwwood wjwwood mentioned this pull request Jan 16, 2026
Merged
@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Jan 27, 2026 •
edited
Loading

Pulls: #88
Gist: https://gist.githubusercontent.com/wjwwood/e5ce5b086b72993f821654ed78fa506e/raw/9219c2bb6c10e3b1fc230371fa447d26cb3db37c/ros2.repos
BUILD args: --packages-above-and-dependencies osrf_testing_tools_cpp
TEST args: --packages-above osrf_testing_tools_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18048

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@mosfet80 mosfet80 mentioned this pull request Mar 9, 2026
Open
@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Mar 24, 2026

Pulls: #88
Gist: https://gist.githubusercontent.com/wjwwood/0d5338f46e8ba75f665392426df54597/raw/9219c2bb6c10e3b1fc230371fa447d26cb3db37c/ros2.repos
BUILD args: --packages-above-and-dependencies osrf_testing_tools_cpp
TEST args: --packages-above osrf_testing_tools_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18650

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Mar 25, 2026 •
edited
Loading

Pulls: #88
Gist: https://gist.githubusercontent.com/ahcorde/16c7d5299dcd1f1f5f1c52c1e1835894/raw/9219c2bb6c10e3b1fc230371fa447d26cb3db37c/ros2.repos
BUILD args: --packages-above-and-dependencies osrf_testing_tools_cpp
TEST args: --packages-above osrf_testing_tools_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18659

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Mar 26, 2026

Most of the test failures in CI look unrelated, but someone should probably look at the tests that are passing but crashing on exit (gtest says OK but non-zero return code) in the aarch64 job, before we merge this. It's possible this could be impacting those, unless those tests explicitly do not use this tool and/or those are known flakes.

Other than that though, this lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjwwood wjwwood wjwwood approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mosfet80 @wjwwood @ahcorde