Skip to content

#51 Submission Validation in a worker thread #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leoraba merged 21 commits into from
Mar 25, 2026
Merged

#51 Submission Validation in a worker thread #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
8613b31
group errors outside loop
leoraba Mar 3, 2026
a36d8ad
combine data to validate improvement
leoraba Mar 3, 2026
0159717
commit worker thread
leoraba Mar 5, 2026
c37773d
db index and new submission status
leoraba Mar 5, 2026
b3ce751
setting up workerpool
leoraba Mar 10, 2026
7a4961b
revert baseDependencies db pool
leoraba Mar 10, 2026
0eeed7c
Merge branch 'main' into commit_submission_worker
leoraba Mar 11, 2026
a5b9495
fix inconsistencies
leoraba Mar 11, 2026
71d9f8a
execute data validation in a worker thread
leoraba Mar 11, 2026
af483f2
Merge branch 'commit_submission_worker' into feat/validate_data_worker
leoraba Mar 11, 2026
b246888
small changes for code readability
leoraba Mar 12, 2026
b79f975
improving TSdocs and small code refactor
leoraba Mar 17, 2026
398b658
refactor groupSchemaDataByEntityName
leoraba Mar 17, 2026
2ccc942
refactor worker pool
leoraba Mar 18, 2026
e9242ab
update comments and logs, revert unused code change
leoraba Mar 18, 2026
ccd5a8b
Merge branch 'commit_submission_worker' into feat/validate_data_worker
leoraba Mar 18, 2026
6918027
Merge branch 'main' into feat/validate_data_worker
leoraba Mar 20, 2026
d71fd1b
using dataValidation workerPool function
leoraba Mar 20, 2026
a6292fe
add enum VALIDATING
leoraba Mar 24, 2026
609844c
update comments and remove unused import
leoraba Mar 24, 2026
d0cdfff
force close submission
leoraba Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions apps/server/swagger/parameters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@ components:
schema:
type: string
required: true
ForceDeleteSubmission:
description: Optional query parameter to force the deletion of a submission. Default value is false
name: force
in: query
schema:
type: boolean
required: false
Comment on lines +39 to +45
Copy link
Copy Markdown
Contributor Author

@leoraba leoraba Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flag added to the DELETE submission endpoint.

OnlyActive:
description: Optional query parameter to filter results to include only active submissions. Default value is false
name: onlyActive
Expand Down
7 changes: 2 additions & 5 deletions apps/server/swagger/submission-api.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,8 @@
tags:
- Submission
parameters:
- name: submissionId
in: path
type: string
required: true
- $ref: '#/components/parameters/path/SubmissionId'
- $ref: '#/components/parameters/query/ForceDeleteSubmission'
responses:
200:
description: Submission closed successfully
Expand Down Expand Up @@ -320,7 +318,6 @@
503:
$ref: '#/components/responses/ServiceUnavailableError'


/submission/category/{categoryId}/data/{systemId}:
delete:
summary: Removes data from a submission using the System ID. Returns an Active Submission containing the records that will be deleted
Expand Down
1 change: 1 addition & 0 deletions packages/data-model/docs/schema.dbml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ enum audit_action {

enum submission_status {
OPEN
VALIDATING
VALID
INVALID
CLOSED
Expand Down
1 change: 1 addition & 0 deletions packages/data-model/migrations/0012_add_submission_enum_validating.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ALTER TYPE "submission_status" ADD VALUE 'VALIDATING';
Loading