Skip to content

feat: add recognition of Lua5.5 if available #3527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
airween wants to merge 1 commit into
base: v2/master
Choose a base branch
from
+1 −1
Open

feat: add recognition of Lua5.5 if available #3527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/find_lua.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ LUA_CPPFLAGS=""
LUA_LDADD=""
LUA_LDFLAGS=""
LUA_CONFIG=${PKG_CONFIG}
LUA_PKGNAMES="lua5.1 lua-5.1 lua_5.1 lua-51 lua_51 lua51 lua5 lua lua5.2 lua-5.2 lua_5.2 lua-52 lua_52 lua52 lua5.3 lua-5.3 lua_5.3 lua-53 lua_53 lua53 "
LUA_PKGNAMES="lua5.5 lua-5.5 lua_5.5 lua-55 lua_55 lua55 lua5.4 lua-5.4 lua_5.4 lua-54 lua_54 lua54 lua5.3 lua-5.3 lua_5.3 lua-53 lua_53 lua53 lua5.2 lua-5.2 lua_5.2 lua-52 lua_52 lua52 lua5.1 lua-5.1 lua_5.1 lua-51 lua_51 lua51 lua5 lua"
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding lua5.5 to LUA_PKGNAMES improves the pkg-config detection path, but the non-pkg-config fallback later in this macro still only probes for liblua5.1/liblua51/liblua. On systems that ship only versioned Lua libraries (e.g., liblua5.5) without a corresponding pkg-config module, configure will still fail to detect Lua despite this update. Consider extending the fallback library probe list to include 5.2–5.5 (or deriving the library names from LUA_PKGNAMES) so the “Lua 5.5 if available” goal is met even when pkg-config metadata is missing.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member Author

@airween airween Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

LUA_SONAMES="so la sl dll dylib a"
AC_ARG_WITH(
Expand Down
Loading