This repository was archived by the owner on Dec 8, 2025. It is now read-only.
Convert Database, AttachmentDatabase and MediaDatabase to Kotlin#1553
Open
bemusementpark wants to merge 13 commits intooxen-io:devfrom
Open
Convert Database, AttachmentDatabase and MediaDatabase to Kotlin#1553bemusementpark wants to merge 13 commits intooxen-io:devfrom
bemusementpark wants to merge 13 commits intooxen-io:devfrom
Conversation
AL-Session
approved these changes
Jul 18, 2024
AL-Session
left a comment
AL-Session
left a comment
There was a problem hiding this comment.
Looks good to me - will approve, but I'd sleep better knowing those two fiddly methods had been tested and we were 100% confident the functionality was the same. If you're 100% then that's good enough for me.
| Log.w(TAG, "Failed to parse shared contacts.", e) | ||
| } | ||
| return emptyList() | ||
| ): List<Contact> = try { |
There was a problem hiding this comment.
This is... tricky. Would love to test that this method still works just for peace of mind.
| Log.w(TAG, "Failed to parse shared contacts.", e) | ||
| } | ||
| return emptyList() | ||
| ): List<LinkPreview> = try { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.