Skip to content

Add badge with IP version to link pool modal#3102

Merged
charliepark merged 1 commit intomainfrom
ip_version_in_pool_dropdown
Mar 5, 2026
Merged

Add badge with IP version to link pool modal#3102
charliepark merged 1 commit intomainfrom
ip_version_in_pool_dropdown

Conversation

@charliepark
Copy link
Contributor

This adds a badge with IP Pool info to the "link pool" dropdown
Screenshot 2026-03-03 at 2 26 55 PM

Closes #3100

@vercel
Copy link

vercel bot commented Mar 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
console Ready Ready Preview Mar 3, 2026 10:32pm

Request Review

@charliepark charliepark marked this pull request as ready for review March 3, 2026 22:40
@charliepark charliepark requested a review from david-crespo March 4, 2026 18:42
Copy link
Collaborator

@david-crespo david-crespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@david-crespo
Copy link
Collaborator

Did you try getting the descriptions in there like you mentioned in
#3100 (comment)? It doesn't have to literally use IpPoolSelector, it could just duplicate the logic or share it some other way. I think it looks a little nicer with the descriptions.

@charliepark charliepark merged commit 615df34 into main Mar 5, 2026
8 checks passed
@charliepark charliepark deleted the ip_version_in_pool_dropdown branch March 5, 2026 22:05
@charliepark
Copy link
Contributor Author

Sorry; hit merge right as your last comment came in. Will revisit the description in a new branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add IP version badge to Link Pool form dropdowns

2 participants