Skip to content

add created_at and updated_at to access page user lists#3104

Closed
charliepark wants to merge 1 commit intomainfrom
add_time_created_and_updated_to_access_pages
Closed

add created_at and updated_at to access page user lists#3104
charliepark wants to merge 1 commit intomainfrom
add_time_created_and_updated_to_access_pages

Conversation

@charliepark
Copy link
Contributor

This builds off of an update to the API in oxidecomputer/omicron#9958, and adds the created and updated timestamps on the various Access pages.

Screenshot 2026-03-04 at 3 29 26 PM

#3095 does not include these columns, but those will be easy to add once oxidecomputer/omicron#9958 has been merged.

@vercel
Copy link

vercel bot commented Mar 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
console Ready Ready Preview Mar 4, 2026 11:35pm

Request Review

@david-crespo
Copy link
Collaborator

david-crespo commented Mar 5, 2026

This doesn't make sense to me as the place to display this info. I would expect to see this on the user and group list views (which we don't have yet).

Fundamentally this table is a list of role assignments, while these timestamps are created and update on the user/group. If these had timestamps I would expect them to be when the roles were assigned. We don't have that, and it wouldn't be very useful anyway since you have to PUT the entire set of assignments every time, which means every assignment in the list would always have the same timestamp.

@charliepark
Copy link
Contributor Author

This page will be moot as soon as we have #3106 in (which adds the user / group tabs), so I'm going to close this one. Once oxidecomputer/omicron#9958 is in, I'll update #3106 to have the appropriate columns.

@charliepark charliepark closed this Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants