Skip to content

fix: bump max instance vcpu to 254 #3108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 1 commit into from
Mar 6, 2026
+8 −9
Merged

fix: bump max instance vcpu to 254 #3108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions app/api/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,15 @@ import type {
VpcFirewallRuleUpdate,
} from './__generated__/Api'

// API limits encoded in https://github.com/oxidecomputer/omicron/blob/44e65c3/nexus/src/app/mod.rs#L130-L161
// API limits encoded in https://github.com/oxidecomputer/omicron/blob/9dd23096de93c7d6d05ea21f6323de4410060652/nexus/src/app/mod.rs#L142

// These are not actually used in app code, just the mock server. In the app we
// can rely on API errors to communicate these limits.
export const MAX_NICS_PER_INSTANCE = 8
export const MAX_DISKS_PER_INSTANCE = 12

// Limit is 254 on the backend but we haven't shipped any hardware that supports
// that, so let's do 128 for now
export const INSTANCE_MAX_CPU = 128
// Limit is 254 on the backend.
export const INSTANCE_MAX_CPU = 254

export const INSTANCE_MIN_RAM_GiB = 1
export const INSTANCE_MAX_RAM_GiB = 1536
Expand Down
8 changes: 4 additions & 4 deletions mock-api/sled.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export const sleds: Json<Sled[]> = [
serial: 'BRM02222869',
revision: 0,
},
usable_hardware_threads: 128,
usable_hardware_threads: 254,
usable_physical_ram: 1_099_511_627_776,
},
{
Expand All @@ -43,7 +43,7 @@ export const sleds: Json<Sled[]> = [
serial: 'BRM02222870',
revision: 0,
},
usable_hardware_threads: 128,
usable_hardware_threads: 254,
usable_physical_ram: 1_099_511_627_776,
},
{
Expand All @@ -60,7 +60,7 @@ export const sleds: Json<Sled[]> = [
serial: 'BRM02222868',
revision: 0,
},
usable_hardware_threads: 128,
usable_hardware_threads: 254,
usable_physical_ram: 1_099_511_627_776,
},
{
Expand All @@ -77,7 +77,7 @@ export const sleds: Json<Sled[]> = [
serial: 'BRM02222867',
revision: 0,
},
usable_hardware_threads: 128,
usable_hardware_threads: 254,
usable_physical_ram: 1_099_511_627_776,
},
]
2 changes: 1 addition & 1 deletion test/e2e/instance-create.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@ test('Validate CPU and RAM', async ({ page }) => {

const submitButton = page.getByRole('button', { name: 'Create instance' })

const cpuMsg = page.getByText('Can be at most 128').first()
const cpuMsg = page.getByText('Can be at most 254').first()
const memMsg = page.getByText('Can be at most 1536 GiB').first()

await expect(cpuMsg).toBeHidden()
Expand Down
Loading