Support glob patterns in copy-to-archive#2432
Merged
Conversation
mkeeter
force-pushed
the
mkeeter/copy-to-archive-glob
branch
from
4cdab12 to
7fc4236
Compare
labbott
reviewed
Mar 11, 2026
Comment on lines
-211
to
-214
|
|
||
| [tasks.cosmo_seq.config] | ||
| fpga_image = "cosmo-a.bin" | ||
| register_defs = "cosmo-regs-a.json" |
Collaborator
There was a problem hiding this comment.
I couldn't find this anywhere so I think it's just cruft?
Collaborator
Author
There was a problem hiding this comment.
Yes, that's why I deleted it 😄
mkeeter
force-pushed
the
mkeeter/copy-to-archive-glob
branch
from
7fc4236 to
92504f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and ship all of the Cosmo sequencer register JSON files
This is a building block for #2279, so that we can look up the correct memory offset.