Prefer using try_lookup_task for better errors#605
Merged
Conversation
labbott
reviewed
Mar 11, 2026
cmd/dump/src/lib.rs
Outdated
Comment on lines
+430
to
+432
| let ndx = match hubris.try_lookup_task(task)? { | ||
| HubrisTask::Task(ndx) => ndx, | ||
| HubrisTask::Kernel => bail!("invalid task \"{task}\""), |
Contributor
There was a problem hiding this comment.
This doesn't look right, I think the bail message should just be "cant dump kernel?"
Contributor
Author
There was a problem hiding this comment.
Sure, this was the old message (which applied to both task lookup failures and "task is the kernel"), but we can be more specific now.
cmd/dump/src/lib.rs
Outdated
Comment on lines
+710
to
+712
| let ndx = match hubris.try_lookup_task(task)? { | ||
| HubrisTask::Task(ndx) => ndx, | ||
| HubrisTask::Kernel => bail!("invalid task \"{task}\""), |
mkeeter
force-pushed
the
mkeeter/per-task-stackmargin
branch
from
53afeda to
5e9d177
Compare
mkeeter
force-pushed
the
mkeeter/try-lookup-task
branch
from
01fcadd to
32dac32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staged on top of #604
That PR added
try_lookup_task, which prints similar task names; this PR uses it where appropriate to get better error messages everywhere. It's only appropriate when the task name is provided by the user, not in cases where the name is specified by Humility (e.g. looking uppowerorudprpc).It also returns the task by value instead of reference, because they're small
Copy-able objects.